review william

Author: fredmnl

lib/auth/streamingV4/trailingChecksumTransform.js

@@ -3,7 +3,9 @@ const { errors } = require('arsenal');
 
 /**
  * This class is designed to handle the chunks sent in a streaming
- * v4 Auth request
+ * unsigned playload trailer request. In this iteration, we are not checking
+ * the checksums, but we are removing them from the stream.
+ * S3C-9732 will deal with checksum verification.
  */
 class TrailingChecksumTransform extends Transform {
     /**
@@ -19,6 +21,21 @@ class TrailingChecksumTransform extends Transform {
         this.streamClosed = false;
     }
 
+    /**
+     * This function is executed when there is no more data to be read but before the stream is closed
+     * We will verify that the trailing checksum structure was upheld
+     *
+     * @param {function} callback - Callback(err, data)
+     * @return {function} executes callback with err if applicable
+     */
+    _flush(callback) {
+        if (!this.streamClosed) {
+            this.log.error('stream ended without closing chunked encoding');
+            return callback(errors.InvalidArgument);
+        }
+        return callback();
+    }
+
     /**
      * This function will remove the trailing checksum from the stream
      *