Skip to content

Commit e41685a

Browse files
CLDSRV-720: Fix file tests null version compat
1 parent f167acd commit e41685a

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/tests.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,9 +392,13 @@ jobs:
392392

393393
file-ft-tests:
394394
strategy:
395+
fail-fast: false
395396
matrix:
396397
include:
397-
- job-name: file-ft-tests
398+
- enable-null-compat: ''
399+
job-name: file-ft-tests
400+
- enable-null-compat: 'true'
401+
job-name: file-ft-tests-null-compat
398402
name: ${{ matrix.job-name }}
399403
runs-on: ubuntu-24.04
400404
needs: build
@@ -404,6 +408,7 @@ jobs:
404408
CLOUDSERVER_IMAGE: ghcr.io/${{ github.repository }}:${{ github.sha }}
405409
MONGODB_IMAGE: ghcr.io/${{ github.repository }}/ci-mongodb:${{ github.sha }}
406410
MPU_TESTING: "yes"
411+
ENABLE_NULL_VERSION_COMPAT_MODE: "${{ matrix.enable-null-compat }}"
407412
JOB_NAME: ${{ matrix.job-name }}
408413
steps:
409414
- name: Checkout

tests/functional/aws-node-sdk/test/utils/init.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ function decodeVersionId(versionId) {
1111
let decodedVersionId;
1212
if (versionId) {
1313
if (versionId === 'null') {
14-
decodedVersionId = nonVersionedObjId;
14+
// At least file backend handles both
15+
decodedVersionId = config.enableNullVersionCompatMode ? nonVersionedObjId : 'null';
1516
} else {
1617
decodedVersionId = versionIdUtils.decode(versionId);
1718
}

0 commit comments

Comments
 (0)