object tests updates post unused functions removal

Author: benzekrimaha

tests/functional/raw-node/test/GCP/object/completeMpu.js

@@ -6,6 +6,7 @@ const { GCP, GcpUtils } = arsenal.storage.data.external.GCP;
 const {
     gcpMpuSetup,
     genUniqID,
+    gcpRetry,
 } = require('../../../utils/gcpUtils');
 const { getRealAwsConfig } =
     require('../../../../aws-node-sdk/test/support/awsConfig');
@@ -99,36 +100,47 @@ describe('GCP: Complete MPU', function testSuite() {
     before(done => {
         config = getRealAwsConfig(credentialOne);
         gcpClient = new GCP(config);
-        async.eachSeries(Object.values(bucketNames),
-            (bucket, next) => {
-                const cmd = new CreateBucketCommand({ Bucket: bucket.Name });
-                gcpClient.send(cmd)
-                    .then(() => next())
-                    .catch(err => {
-                        process.stdout.write(`err in creating bucket ${err}\n`);
-                        return next(err);
-                    });
-            },
-        done);
+        const buckets = Object.values(bucketNames);
+        async.eachSeries(
+            buckets,
+            (bucket, next) => gcpRetry(
+                gcpClient,
+                () => new CreateBucketCommand({ Bucket: bucket.Name }),
+                null,
+                err => {
+                    if (err) {
+                        process.stdout.write(
+                            `err in creating bucket ${err}\n`);
+                    }
+                    return next(err);
+                },
+            ),
+            done,
+        );
     });
 
     after(done => {
-        async.eachSeries(Object.values(bucketNames),
+        const buckets = Object.values(bucketNames);
+        async.eachSeries(
+            buckets,
             (bucket, next) => emptyBucket(gcpClient, bucket.Name, err => {
                 assert.equal(err, null,
                     `Expected success, but got error ${err}`);
-                const cmd = new DeleteBucketCommand({ Bucket: bucket.Name });
-                gcpClient.send(cmd)
-                    .then(() => next())
-                    .catch(error => {
+                gcpRetry(
+                    gcpClient,
+                    () => new DeleteBucketCommand({ Bucket: bucket.Name }),
+                    null,
+                    error => {
                         if (error) {
                             process.stdout.write(
                                 `err in deleting bucket ${error}\n`);
                         }
                         return next(error);
-                    });
+                    },
+                );
             }),
-        done);
+            done,
+        );
     });
 
     describe('when MPU has 0 parts', () => {