Skip to content

Support miria location#5766

Merged
bert-e merged 3 commits intodevelopment/9.0from
improvement/CLDSRV-624
Mar 20, 2025
Merged

Support miria location#5766
bert-e merged 3 commits intodevelopment/9.0from
improvement/CLDSRV-624

Conversation

@francoisferrand
Copy link
Copy Markdown
Contributor

@francoisferrand francoisferrand commented Mar 19, 2025

  • Add tlp location type
  • Remove dmf and azure_archive location types

Issue: CLDSRV-624

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 19, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 19, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Comment on lines +377 to +383
if (locationConstraints[l].type === 'tlp') {
// should have no detail
assert(Object.keys(locationConstraints[l].details).length === 0);

// should be a cold location
assert(locationConstraints[l].isCold === true);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we stop validating the locations here? is it because we rely on the validation at the location creation time? If yes, can we put a comment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean "stop" validating locations?

  • we keep the whole validation, there is no early exit
  • we do not store any details anymore (as they are useless for cloudserver, and contain secrets), so the validation of these details is now removed, and we now check that details is indeed empty
  • the block was just moved early to simplify testing no details are provided (since default fields are added later in the process)

@francoisferrand
Copy link
Copy Markdown
Contributor Author

/approve

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.44%. Comparing base (0fe6084) to head (32a1ae8).
Report is 3 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 74.29% <100.00%> (-0.83%) ⬇️
@@                 Coverage Diff                 @@
##           development/9.0    #5766      +/-   ##
===================================================
- Coverage            65.52%   65.44%   -0.09%     
===================================================
  Files                  186      186              
  Lines                11737    11699      -38     
===================================================
- Hits                  7691     7656      -35     
+ Misses                4046     4043       -3     
Flag Coverage Δ
unit 65.44% <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 20, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-624.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 32a1ae8 into development/9.0 Mar 20, 2025
19 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-624 branch March 20, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants