Conversation
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
| if (locationConstraints[l].type === 'tlp') { | ||
| // should have no detail | ||
| assert(Object.keys(locationConstraints[l].details).length === 0); | ||
|
|
||
| // should be a cold location | ||
| assert(locationConstraints[l].isCold === true); | ||
| } |
There was a problem hiding this comment.
Why do we stop validating the locations here? is it because we rely on the validation at the location creation time? If yes, can we put a comment?
There was a problem hiding this comment.
what do you mean "stop" validating locations?
- we keep the whole validation, there is no early exit
- we do not store any details anymore (as they are useless for cloudserver, and contain secrets), so the validation of these details is now removed, and we now check that
detailsis indeed empty - the block was just moved early to simplify testing no details are provided (since default fields are added later in the process)
|
/approve |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
@@ Coverage Diff @@
## development/9.0 #5766 +/- ##
===================================================
- Coverage 65.52% 65.44% -0.09%
===================================================
Files 186 186
Lines 11737 11699 -38
===================================================
- Hits 7691 7656 -35
+ Misses 4046 4043 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-624. Goodbye francoisferrand. The following options are set: approve |
Issue: CLDSRV-624