Skip to content

CLDSRV-621: Support bucket owner#5785

Merged
bert-e merged 4 commits intodevelopment/9.0from
improvement/CLDSRV-621/support_bucket_owner_id
Apr 8, 2025
Merged

CLDSRV-621: Support bucket owner#5785
bert-e merged 4 commits intodevelopment/9.0from
improvement/CLDSRV-621/support_bucket_owner_id

Conversation

@tmacro
Copy link
Copy Markdown
Contributor

@tmacro tmacro commented Apr 7, 2025

This PR adds support for the bucketOwnerId ObjectMD property.

This is only set on new created objects (Put, Copy, MPU) as metadata only operations (PutTagging, etc) do not cause an upgrade in the ObjectMD model and introducing one would cause problems as the information needed to correctly do the upgrade may not be available.

bucketOwnerId is also added to the requested overhead fields.

A small bugfix is also included to set owner-id in mpu part metadata when doing CopyPart. This is to match existing behavior in PutPart.

Note for reviewers:
The test for copy-object is intentionally skipped as it is blocked by a bug in bucket policies.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Apr 7, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.19%. Comparing base (73c100b) to head (3893ec2).
Report is 17 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/objectCopy.js 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/object/createAndStoreObject.js 78.98% <100.00%> (+0.30%) ⬆️
lib/api/completeMultipartUpload.js 87.19% <100.00%> (+0.12%) ⬆️
lib/api/objectPutCopyPart.js 73.07% <ø> (ø)
lib/services.js 82.80% <100.00%> (+0.09%) ⬆️
lib/api/objectCopy.js 76.52% <50.00%> (-0.24%) ⬇️
@@               Coverage Diff                @@
##           development/9.0    #5785   +/-   ##
================================================
  Coverage            74.18%   74.19%           
================================================
  Files                  186      186           
  Lines                11751    11759    +8     
================================================
+ Hits                  8718     8725    +7     
- Misses                3033     3034    +1     
Flag Coverage Δ
ceph-backend-test 44.33% <55.55%> (+<0.01%) ⬆️
file-ft-tests 47.58% <55.55%> (+<0.01%) ⬆️
kmip-ft-tests 26.54% <44.44%> (+<0.01%) ⬆️
mongo-v0-ft-tests 47.87% <55.55%> (+<0.01%) ⬆️
mongo-v1-ft-tests 47.89% <55.55%> (+<0.01%) ⬆️
multiple-backend 32.10% <33.33%> (-0.01%) ⬇️
quota-tests 32.17% <33.33%> (-0.84%) ⬇️
quota-tests-inflights 34.14% <44.44%> (-0.04%) ⬇️
unit 65.75% <88.88%> (+0.01%) ⬆️
utapi-v2-tests 33.36% <55.55%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tmacro tmacro force-pushed the improvement/CLDSRV-621/support_bucket_owner_id branch from 4e014c6 to 915946a Compare April 7, 2025 17:50
@tmacro
Copy link
Copy Markdown
Contributor Author

tmacro commented Apr 7, 2025

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@tmacro tmacro force-pushed the improvement/CLDSRV-621/support_bucket_owner_id branch from 915946a to 3893ec2 Compare April 7, 2025 18:29
@tmacro
Copy link
Copy Markdown
Contributor Author

tmacro commented Apr 7, 2025

/reset

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: create_integration_branches

@scality scality deleted a comment from bert-e Apr 7, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 7, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@tmacro
Copy link
Copy Markdown
Contributor Author

tmacro commented Apr 8, 2025

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2025

Build failed

The build for commit did not succeed in branch w/9.1/improvement/CLDSRV-621/support_bucket_owner_id

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 8, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-621.

Goodbye tmacro.

@bert-e bert-e merged commit 0f788ab into development/9.0 Apr 8, 2025
19 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-621/support_bucket_owner_id branch April 8, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants