CLDSRV-657: Fix kmip tests to use pykmip#5824
Conversation
kmip tests were not using pykmip but file kms... Seems to be since migration from eve to GHA (Issue CLDSRV-244) where the kmip config via env was forgotten. Lost here: https://github.com/scality/cloudserver/pull/4926/files#diff-b0a705e0cbace75695b5e1e57b39c3a73ba96df02fd969ce4c16fd0a9a05df0cL96-L113 I change the ssl-kmip mount in container to match the same path on host and container for certs as we will reuse the same config on host to run tests (sse migration)
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
|
/create_integration_branches |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
There was a problem hiding this comment.
Pull Request Overview
This PR updates configuration and CI settings to enable KMIP tests using the pykmip provider.
- Adds a new
kmipconfig section inconfig.jsonwithproviderName. - Supplies KMIP-related environment variables in GitHub Actions for tests.
- Adjusts the Docker Compose mount path and corrects an environment variable key.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config.json | Introduce top-level kmip block with provider |
| .github/workflows/tests.yaml | Define S3KMS and KMIP env vars for CI jobs |
| .github/docker/docker-compose.yaml | Change /tmp/ssl-kmip mount path; fix S3KMIP_COMPOUND_CREATE |
Comments suppressed due to low confidence (2)
.github/docker/docker-compose.yaml:34
- The
S3KMIP_CERTandS3KMIP_CAvariables are set in the workflow but not passed into the container. Consider adding- S3KMIP_CERTand- S3KMIP_CAunderenvironmentso the container receives these paths.
- S3KMIP_KEY
config.json:99
- [nitpick] Add a short comment or update README/docs to explain the new
kmipsection and itsproviderNamefield so users know how to configure other KMIP parameters (e.g., host, port, certificates).
"kmip": {
|
/approve |
Build failedThe build for commit did not succeed in branch w/9.0/improvement/CLDSRV-657-fix-kmip-tests The following options are set: approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-657. Goodbye bourgoismickael. The following options are set: approve, create_integration_branches |
kmip tests were not using pykmip but file kms...
Seems to be since migration from eve to GHA (Issue CLDSRV-244)
where the kmip config via env was forgotten.
Lost here: https://github.com/scality/cloudserver/pull/4926/files#diff-b0a705e0cbace75695b5e1e57b39c3a73ba96df02fd969ce4c16fd0a9a05df0cL96-L113
I change the ssl-kmip mount in container to match the same
path on host and container for certs as we will reuse the
same config on host to run tests (sse migration)