Skip to content

Fix VaultClient errors not being properly forwarded#5827

Merged
bert-e merged 2 commits intodevelopment/9.0from
bugfix/CLDSRV-666
Jun 13, 2025
Merged

Fix VaultClient errors not being properly forwarded#5827
bert-e merged 2 commits intodevelopment/9.0from
bugfix/CLDSRV-666

Conversation

@welansari
Copy link
Copy Markdown

Issue: CLDSRV-666

This bump introduces a fix to VaulClient
errors not being properly returned as
Arsenal errors

Issue: CLDSRV-666
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 13, 2025

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 13, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@welansari
Copy link
Copy Markdown
Author

welansari commented Jun 13, 2025

/create_integration_branches

@scality scality deleted a comment from bert-e Jun 13, 2025
@scality scality deleted a comment from bert-e Jun 13, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 13, 2025

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/CLDSRV-666 into
    development/9.0
  • w/9.1/bugfix/CLDSRV-666 will be merged into development/9.1

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 13, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.84%. Comparing base (6285a15) to head (7fee024).
Report is 2 commits behind head on development/9.0.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           development/9.0    #5827   +/-   ##
================================================
  Coverage            75.84%   75.84%           
================================================
  Files                  188      188           
  Lines                11963    11963           
================================================
  Hits                  9073     9073           
  Misses                2890     2890           
Flag Coverage Δ
ceph-backend-test 46.92% <ø> (ø)
file-ft-tests 47.30% <ø> (ø)
kmip-ft-tests 26.93% <ø> (ø)
mongo-v0-ft-tests 47.73% <ø> (ø)
mongo-v1-ft-tests 47.75% <ø> (ø)
multiple-backend 35.46% <ø> (ø)
quota-tests 32.19% <ø> (-0.04%) ⬇️
quota-tests-inflights 34.18% <ø> (-0.01%) ⬇️
unit 66.83% <ø> (ø)
utapi-v2-tests 33.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@welansari
Copy link
Copy Markdown
Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 13, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-666.

Goodbye kerkesni.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit 7fee024 into development/9.0 Jun 13, 2025
19 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-666 branch June 13, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants