Skip to content

CLDSRV-670: Fix linting in sse kms test files#5847

Merged
bert-e merged 2 commits intodevelopment/7.70from
improvement/CLDSRV-670-test-linting
Jun 25, 2025
Merged

CLDSRV-670: Fix linting in sse kms test files#5847
bert-e merged 2 commits intodevelopment/7.70from
improvement/CLDSRV-670-test-linting

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

Reactivate eslint in sse kms test files & ignore no-unused-expressions to remove all void and fix linting

This comment was marked as outdated.

@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-670-kms-copy branch 2 times, most recently from 245f55f to 6ddaddd Compare June 25, 2025 09:03
Base automatically changed from improvement/CLDSRV-670-kms-copy to development/7.70 June 25, 2025 09:49
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 25, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

This comment was marked as outdated.

@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-670-test-linting branch from 986a7c5 to 49830f8 Compare June 25, 2025 09:59
@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 25, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/8.8/improvement/CLDSRV-670-test-linting with contents from improvement/CLDSRV-670-test-linting
and development/8.8.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.8/improvement/CLDSRV-670-test-linting origin/development/8.8
 $ git merge origin/improvement/CLDSRV-670-test-linting
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.8/improvement/CLDSRV-670-test-linting

The following options are set: create_integration_branches

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 25, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/9.0/improvement/CLDSRV-670-test-linting with contents from w/8.8/improvement/CLDSRV-670-test-linting
and development/9.0.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/9.0/improvement/CLDSRV-670-test-linting origin/development/9.0
 $ git merge origin/w/8.8/improvement/CLDSRV-670-test-linting
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/9.0/improvement/CLDSRV-670-test-linting

The following options are set: approve, create_integration_branches

@bert-e

This comment was marked as outdated.

@bert-e

This comment was marked as outdated.

@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-670-test-linting branch from 49830f8 to 14a7779 Compare June 25, 2025 17:48
@bert-e

This comment was marked as outdated.

@bert-e

This comment was marked as outdated.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 25, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve, create_integration_branches

@scality scality deleted a comment from bert-e Jun 25, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 25, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.70

  • ✔️ development/8.8

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4

Please check the status of the associated issue CLDSRV-670.

Goodbye bourgoismickael.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit 14a7779 into development/7.70 Jun 25, 2025
17 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-670-test-linting branch June 25, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants