Skip to content

[backport] Fix AbortMPU conditional deletion of wrong data#5850

Merged
bert-e merged 3 commits intohotfix/8.8.45from
bugfix/CLDSRV-668-backport-8.8.45
Jun 26, 2025
Merged

[backport] Fix AbortMPU conditional deletion of wrong data#5850
bert-e merged 3 commits intohotfix/8.8.45from
bugfix/CLDSRV-668-backport-8.8.45

Conversation

@francoisferrand
Copy link
Copy Markdown
Contributor

Backport from #5849

Issue: CLDSRV-668

Add functional tests to cover scenarios where aborting an MPU
could delete data from a different, completed MPU with the
same object key.

This prevents a regression of a bug where the wrong data was
deleted because the uploadId was not being checked when
looking for object metadata to clean up during an abort.

Issue: CLDSRV-668
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 26, 2025

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

> This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner will be removed on 2025-04-15. For more details, see actions/runner-images#11101

Issue: CLDSRV-668
@francoisferrand francoisferrand force-pushed the bugfix/CLDSRV-668-backport-8.8.45 branch from b334715 to 60784af Compare June 26, 2025 13:16
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (ae827d7) to head (60784af).
Report is 3 commits behind head on hotfix/8.8.45.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/object/abortMultipartUpload.js 84.81% <100.00%> (ø)
@@              Coverage Diff               @@
##           hotfix/8.8.45    #5850   +/-   ##
==============================================
  Coverage          65.39%   65.39%           
==============================================
  Files                186      186           
  Lines              11708    11708           
==============================================
  Hits                7657     7657           
  Misses              4051     4051           
Flag Coverage Δ
unit 65.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@francoisferrand francoisferrand changed the title Fix AbortMPU conditional deletion of wrong data [backport] Fix AbortMPU conditional deletion of wrong data Jun 26, 2025
@francoisferrand
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jun 26, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/8.8.45

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-668.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit 60784af into hotfix/8.8.45 Jun 26, 2025
20 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-668-backport-8.8.45 branch June 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants