Skip to content

CLDSRV-717: Minor fixes#5860

Merged
bert-e merged 1 commit intodevelopment/9.0from
improvement/CLDSRV-717-fixes-unification
Jul 18, 2025
Merged

CLDSRV-717: Minor fixes#5860
bert-e merged 1 commit intodevelopment/9.0from
improvement/CLDSRV-717-fixes-unification

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

I caught while reviewing branch diff for unification

I caught while reviewing branch diff for unification
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-717 contains:

  • 8.2.21

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.20

  • 9.1.0

Please check the Fix Version/s of CLDSRV-717, or the target
branch of this pull request.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.84%. Comparing base (ad9dcea) to head (b36727b).
⚠️ Report is 237 commits behind head on development/9.0.

Files with missing lines Patch % Lines
lib/api/objectGet.js 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/authorization/permissionChecks.js 87.68% <100.00%> (ø)
lib/api/objectGet.js 53.61% <0.00%> (ø)

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5860      +/-   ##
===================================================
- Coverage            75.88%   75.84%   -0.05%     
===================================================
  Files                  188      188              
  Lines                11969    11969              
===================================================
- Hits                  9083     9078       -5     
- Misses                2886     2891       +5     
Flag Coverage Δ
ceph-backend-test 46.92% <50.00%> (ø)
file-ft-tests 47.30% <50.00%> (-0.05%) ⬇️
kmip-ft-tests 26.95% <50.00%> (ø)
mongo-v0-ft-tests 47.73% <50.00%> (ø)
mongo-v1-ft-tests 47.75% <50.00%> (ø)
multiple-backend 35.45% <50.00%> (ø)
quota-tests 32.24% <50.00%> (-0.84%) ⬇️
quota-tests-inflights 34.18% <50.00%> (ø)
unit 66.82% <50.00%> (ø)
utapi-v2-tests 33.30% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael BourgoisMickael requested review from a user, benzekrimaha and welansari July 17, 2025 17:09
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 18, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 18, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 18, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-717.

Goodbye bourgoismickael.

@bert-e bert-e merged commit 86f9fe7 into development/9.0 Jul 18, 2025
25 of 26 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-717-fixes-unification branch July 18, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants