Skip to content

CLDSRV-716#5861

Merged
bert-e merged 4 commits intohotfix/9.0.7from
bugfix/CLDSRV-716
Jul 17, 2025
Merged

CLDSRV-716#5861
bert-e merged 4 commits intohotfix/9.0.7from
bugfix/CLDSRV-716

Conversation

@benzekrimaha
Copy link
Copy Markdown
Contributor

@benzekrimaha benzekrimaha commented Jul 17, 2025 •
edited
Loading

Issue: CLDSRV-716

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-716 contains:

  • None

Considering where you are trying to merge, I expected to find at least:

  • 9.0.7.2

Please check the Fix Version/s of CLDSRV-716, or the target
branch of this pull request.

@benzekrimaha benzekrimaha changed the title Bugfix/cldsrv 716 CLDSRV-716 Jul 17, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.73%. Comparing base (c628f1c) to head (217a4b7).
Report is 4 commits behind head on hotfix/9.0.7.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/server.js 75.43% <100.00%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

@@               Coverage Diff                @@
##           hotfix/9.0.7    #5861      +/-   ##
================================================
+ Coverage         73.69%   73.73%   +0.03%     
================================================
  Files               186      186              
  Lines             11719    11721       +2     
================================================
+ Hits               8636     8642       +6     
+ Misses             3083     3079       -4
Flag Coverage Δ
ceph-backend-test 44.24% <100.00%> (+<0.01%) ⬆️
file-ft-tests 47.52% <100.00%> (+<0.01%) ⬆️
kmip-ft-tests 26.46% <100.00%> (+0.01%) ⬆️
mongo-v0-ft-tests 47.84% <100.00%> (+<0.01%) ⬆️
mongo-v1-ft-tests 47.86% <100.00%> (+<0.01%) ⬆️
multiple-backend 31.99% <100.00%> (+0.01%) ⬆️
quota-tests 32.94% <100.00%> (-0.03%) ⬇️
quota-tests-inflights 34.07% <100.00%> (-0.03%) ⬇️
unit 66.32% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benzekrimaha benzekrimaha requested a review from welansari July 17, 2025 10:06
@benzekrimaha benzekrimaha requested a review from a user July 17, 2025 10:08
@benzekrimaha
Disable default timeout
9a112b9 
Starting node 18 we now have a default timeout of
300000 ( 5 minutes) set , which is not suitable for our use cases.
This commit disables the default timeout by setting the
server.requestTimeout to 0
https://nodejs.org/api/http.html#serverrequesttimeout

Issue: CLDSRV-716
@scality scality deleted a comment from bert-e Jul 17, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

benzekrimaha and others added 3 commits July 17, 2025 12:55
@benzekrimaha
unit test addition for timeout disabing
e275817 
Issue: CLDSRV-716
@benzekrimaha
ci: upgrade Ruby to 3.2 and modernize gem dependencies
b9179da 
- Upgrade Ruby from 2.5.9 to 3.2 in ceph-backend-test job
- Update gem versions for Ruby 3.2 compatibility:
  - nokogiri: 1.12.5 → 1.15.5
  - excon: 0.109.0 → 0.111.0
  - fog-aws: 1.3.0 → 3.19.0
  - mime-types: 3.1 → 3.5.2
  - rspec: 3.5 → 3.12.0
- Fixes "Proc object without a block" and numbered parameter syntax errors
- Resolves multi_json dependency conflicts with modern Ruby versions

Issue: CLDSRV-715
@benzekrimaha
bump project version
217a4b7 
Issue: CLDSRV-716
@benzekrimaha
Copy link
Copy Markdown
Contributor Author

benzekrimaha commented Jul 17, 2025

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/9.0.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-716.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit 217a4b7 into hotfix/9.0.7 Jul 17, 2025
19 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-716 branch July 17, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@welansari welansari welansari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benzekrimaha @bert-e @welansari