Skip to content

set 20kb payload limit on putBucketPolicy#5866

Merged
bert-e merged 2 commits intodevelopment/9.1from
bug/CLDSRV-700
Jul 31, 2025
Merged

set 20kb payload limit on putBucketPolicy#5866
bert-e merged 2 commits intodevelopment/9.1from
bug/CLDSRV-700

Conversation

@SylvainSenechal
Copy link
Copy Markdown
Contributor

@SylvainSenechal SylvainSenechal commented Jul 17, 2025

Issue: CLDSRV-700

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.26%. Comparing base (4b53e38) to head (2ca749c).
⚠️ Report is 2 commits behind head on development/9.1.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 79.35% <100.00%> (+0.16%) ⬆️
lib/api/api.js 89.58% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.1    #5866      +/-   ##
===================================================
+ Coverage            83.22%   83.26%   +0.04%     
===================================================
  Files                  188      188              
  Lines                12100    12108       +8     
===================================================
+ Hits                 10070    10082      +12     
+ Misses                2030     2026       -4     
Flag Coverage Δ
ceph-backend-test 64.24% <100.00%> (+<0.01%) ⬆️
file-ft-tests 66.11% <100.00%> (+0.05%) ⬆️
kmip-ft-tests 26.94% <86.66%> (+0.04%) ⬆️
mongo-v0-ft-tests 67.92% <100.00%> (+0.02%) ⬆️
mongo-v1-ft-tests 67.92% <100.00%> (+<0.01%) ⬆️
multiple-backend 33.91% <100.00%> (+0.04%) ⬆️
sur-tests 34.52% <100.00%> (+0.07%) ⬆️
sur-tests-inflights 36.46% <100.00%> (+0.02%) ⬆️
unit 67.30% <86.66%> (+0.02%) ⬆️
utapi-v2-tests 33.29% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 3 times, most recently from 630f78a to 32b0194 Compare July 17, 2025 13:37
Comment thread constants.js Outdated
@SylvainSenechal SylvainSenechal marked this pull request as ready for review July 17, 2025 14:26
Comment thread lib/api/bucketPutPolicy.js Outdated
@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 2 times, most recently from ee4f7a3 to 47774c5 Compare July 17, 2025 19:06
Comment thread lib/api/bucketPutPolicy.js Outdated
@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 3 times, most recently from 236f5cb to b1b62c9 Compare July 22, 2025 12:51
Comment thread lib/Config.js Outdated
Comment thread config.json Outdated
Comment thread constants.js Outdated
Comment thread config.json
Comment thread lib/Config.js Outdated
@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 8 times, most recently from f3b04a7 to cfecc63 Compare July 30, 2025 12:52
Comment thread lib/Config.js
@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 2 times, most recently from e6abe9b to fd8e2a4 Compare July 31, 2025 16:22
Comment thread lib/Config.js Outdated
Comment thread lib/Config.js Outdated
@francoisferrand
Copy link
Copy Markdown
Contributor

please also rebase and bump cloudserver version (9.1.0-preview.1) for release

@SylvainSenechal SylvainSenechal force-pushed the bug/CLDSRV-700 branch 3 times, most recently from 189e04e to 0cbdff3 Compare July 31, 2025 16:49
Comment thread lib/api/api.js Outdated
Copy link
Copy Markdown
Contributor

@BourgoisMickael BourgoisMickael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can include a functional test for PutBucketPolicy & MultiObjectDelete

@SylvainSenechal
Copy link
Copy Markdown
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jul 31, 2025
@bert-e bert-e merged commit 2ca749c into development/9.1 Jul 31, 2025
27 checks passed
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 31, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0

Please check the status of the associated issue CLDSRV-700.

Goodbye sylvainsenechal.

The following options are set: approve

@bert-e bert-e deleted the bug/CLDSRV-700 branch July 31, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants