Skip to content

CLDSRV-717: Fix & drop config root redis for utapi#5891

Merged
bert-e merged 1 commit intodevelopment/9.0from
improvement/CLDSRV-717-redis
Jul 29, 2025
Merged

CLDSRV-717: Fix & drop config root redis for utapi#5891
bert-e merged 1 commit intodevelopment/9.0from
improvement/CLDSRV-717-redis

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

Currently, root redis is not defined neither by zenko or s3c. This breaks utapi replay with overrided redis config.

There has been multiple tickets S3C-1399 ZENKO-345 ZENKO-1051 ZENKO-3294

In the end root redis is not used and utapi should use utapi.redis and cloudserver uses localCache.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 28, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 28, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-717 contains:

  • 9.0.22

  • 9.0.23

  • 9.1.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.23

  • 9.1.0

Please check the Fix Version/s of CLDSRV-717, or the target
branch of this pull request.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.11%. Comparing base (73488a3) to head (33e571e).
⚠️ Report is 1 commits behind head on development/9.0.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/Config.js 0.00% 1 Missing ⚠️
lib/utapi/utapi.js 0.00% 1 Missing ⚠️
lib/utapi/utapiReplay.js 0.00% 1 Missing ⚠️
lib/utapi/utilities.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/Config.js 79.18% <0.00%> (-0.12%) ⬇️
lib/utapi/utapi.js 0.00% <0.00%> (ø)
lib/utapi/utapiReplay.js 0.00% <0.00%> (ø)
lib/utapi/utilities.js 37.41% <0.00%> (+0.53%) ⬆️
@@               Coverage Diff                @@
##           development/9.0    #5891   +/-   ##
================================================
  Coverage            83.10%   83.11%           
================================================
  Files                  188      188           
  Lines                12048    12046    -2     
================================================
- Hits                 10013    10012    -1     
+ Misses                2035     2034    -1     
Flag Coverage Δ
ceph-backend-test 65.65% <0.00%> (+0.02%) ⬆️
file-ft-tests 66.02% <0.00%> (+0.01%) ⬆️
kmip-ft-tests 26.93% <0.00%> (+<0.01%) ⬆️
mongo-v0-ft-tests 67.87% <0.00%> (+0.01%) ⬆️
mongo-v1-ft-tests 67.87% <0.00%> (+0.01%) ⬆️
multiple-backend 35.43% <0.00%> (+<0.01%) ⬆️
quota-tests 33.01% <0.00%> (+0.83%) ⬆️
quota-tests-inflights 34.15% <0.00%> (+<0.01%) ⬆️
unit 67.10% <0.00%> (+<0.01%) ⬆️
utapi-v2-tests 33.28% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael BourgoisMickael requested review from a user, francoisferrand and welansari July 28, 2025 15:02
Comment thread lib/Config.js Outdated
Currently, root redis is not defined neither by zenko or s3c.
This breaks utapi replay with overrided redis config.

There has been multiple tickets S3C-1399 ZENKO-345 ZENKO-1051 ZENKO-3294

In the end root redis is not used and utapi should use utapi.redis
and cloudserver uses localCache.
@BourgoisMickael BourgoisMickael force-pushed the improvement/CLDSRV-717-redis branch from a4728f0 to 33e571e Compare July 29, 2025 07:47
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jul 29, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-717.

Goodbye bourgoismickael.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit 33e571e into development/9.0 Jul 29, 2025
26 of 27 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-717-redis branch July 29, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants