CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… by leif-scality · Pull Request #5899 · scality/cloudserver

leif-scality · 2025-08-08T17:15:00Z

Like explained in the Jira ticket newer AWS sdk version no longer send the content-md5 header, so remove the requirement here.

Integration OK: https://github.com/scality/Integration/actions/runs/16907683924

bert-e · 2025-08-08T17:15:04Z

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-08-08T17:15:09Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-729 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.0.23
9.1.0

Please check the Fix Version/s of CLDSRV-729, or the target
branch of this pull request.

codecov · 2025-08-08T17:18:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.19%. Comparing base (091fd27) to head (36120ba).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/bucketPutCors.js	`80.35% <100.00%> (+0.35%)`	⬆️
lib/api/multiObjectDelete.js	`80.29% <100.00%> (+0.07%)`	⬆️

@@               Coverage Diff                @@
##           development/9.0    #5899   +/-   ##
================================================
  Coverage            83.19%   83.19%           
================================================
  Files                  188      188           
  Lines                12091    12093    +2     
================================================
+ Hits                 10059    10061    +2     
  Misses                2032     2032

Flag	Coverage Δ
ceph-backend-test	`65.65% <54.54%> (-0.02%)`	⬇️
file-ft-tests	`66.03% <72.72%> (+<0.01%)`	⬆️
kmip-ft-tests	`26.83% <0.00%> (-0.01%)`	⬇️
mongo-v0-ft-tests	`67.88% <72.72%> (+<0.01%)`	⬆️
mongo-v1-ft-tests	`67.88% <72.72%> (-0.02%)`	⬇️
multiple-backend	`35.30% <0.00%> (-0.01%)`	⬇️
quota-tests	`32.09% <27.27%> (+<0.01%)`	⬆️
quota-tests-inflights	`34.03% <27.27%> (+<0.01%)`	⬆️
unit	`67.28% <100.00%> (+0.03%)`	⬆️
utapi-v2-tests	`33.20% <27.27%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…elete-objects

bert-e · 2025-08-12T08:43:29Z

Branches have diverged

This pull request's source branch bugfix/CLDSRV-729-remove-md5-header-requirement has diverged from
development/9.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

Merge origin/development/9.0 into bugfix/CLDSRV-729-remove-md5-header-requirement
Rebase bugfix/CLDSRV-729-remove-md5-header-requirement onto origin/development/9.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

bert-e · 2025-08-12T08:43:45Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-729 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.70.76
8.8.57
9.0.23
9.1.0

Please check the Fix Version/s of CLDSRV-729, or the target
branch of this pull request.

leif-scality · 2025-08-12T14:31:46Z

ping

bert-e · 2025-08-12T14:31:54Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-729 contains:

7.70.76

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

7.70.76
8.8.57
9.0.23
9.1.0

Please check the Fix Version/s of CLDSRV-729, or the target
branch of this pull request.

leif-scality · 2025-08-12T14:36:29Z

ping

bert-e · 2025-08-12T14:36:39Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

leif-scality · 2025-08-12T14:36:47Z

/create_integration_branches

bert-e · 2025-08-12T14:36:59Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement with contents from bugfix/CLDSRV-729-remove-md5-header-requirement
and development/8.8.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement origin/development/8.8
 $ git merge origin/bugfix/CLDSRV-729-remove-md5-header-requirement
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement

The following options are set: create_integration_branches

leif-scality · 2025-08-12T14:40:12Z

ping

bert-e · 2025-08-12T14:40:22Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-729-remove-md5-header-requirement into
development/7.70
w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/8.8
w/9.0/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.0
w/9.1/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.1

The following branches will NOT be impacted:

development/7.10
development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2025-08-12T14:40:23Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

leif-scality · 2025-08-12T14:40:41Z

/create_pull_requests

bert-e · 2025-08-12T14:40:57Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-729-remove-md5-header-requirement into
development/7.70
w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/8.8 (pull request INTEGRATION [PR#5899 > development/8.8] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5900)
w/9.0/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.0 (pull request INTEGRATION [PR#5899 > development/9.0] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5901)
w/9.1/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.1 (pull request INTEGRATION [PR#5899 > development/9.1] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5902)

The following branches will NOT be impacted:

development/7.10
development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2025-08-12T14:40:58Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2025-08-12T14:48:49Z

Conflict

A conflict has been raised during the creation of
integration branch w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement with contents from bugfix/CLDSRV-729-remove-md5-header-requirement
and development/8.8.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement origin/development/8.8
 $ git merge origin/bugfix/CLDSRV-729-remove-md5-header-requirement
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement

The following options are set: create_pull_requests, create_integration_branches

leif-scality · 2025-08-12T14:49:33Z

/create_integration_branches

leif-scality · 2025-08-12T14:52:59Z

ping

bert-e · 2025-08-12T14:53:16Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-729-remove-md5-header-requirement into
development/7.70
w/8.8/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/8.8 (pull request INTEGRATION [PR#5899 > development/8.8] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5903)
w/9.0/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.0 (pull request INTEGRATION [PR#5899 > development/9.0] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5904)
w/9.1/bugfix/CLDSRV-729-remove-md5-header-requirement will be merged into development/9.1 (pull request INTEGRATION [PR#5899 > development/9.1] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5905)

The following branches will NOT be impacted:

development/7.10
development/7.4

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2025-08-12T14:53:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

leif-scality · 2025-08-12T14:58:38Z

/approve

leif-scality · 2025-08-12T15:31:59Z

ping

bert-e · 2025-08-12T15:32:21Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/7.70
✔️ development/8.8
✔️ development/9.0
✔️ development/9.1

The following branches have NOT changed:

development/7.10
development/7.4

Please check the status of the associated issue CLDSRV-729.

Goodbye leif-scality.

The following options are set: approve, create_pull_requests, create_integration_branches

leif-scality force-pushed the bugfix/CLDSRV-729-remove-md5-header-requirement branch 2 times, most recently from 3705614 to 36120ba Compare August 8, 2025 17:22

tcarmet approved these changes Aug 8, 2025

View reviewed changes

tmacro approved these changes Aug 8, 2025

View reviewed changes

CLDSRV-729: don't require content-md5 header in put-bucket-cors and d…

e529da9

…elete-objects

leif-scality force-pushed the bugfix/CLDSRV-729-remove-md5-header-requirement branch from 36120ba to e529da9 Compare August 12, 2025 08:43

leif-scality changed the base branch from development/9.0 to development/7.70 August 12, 2025 08:43

fix lint

8ed743d

This was referenced Aug 12, 2025

INTEGRATION [PR#5899 > development/8.8] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5900

Closed

INTEGRATION [PR#5899 > development/9.0] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5901

Closed

bert-e mentioned this pull request Aug 12, 2025

INTEGRATION [PR#5899 > development/9.1] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5902

Closed

This was referenced Aug 12, 2025

INTEGRATION [PR#5899 > development/8.8] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5903

Merged

INTEGRATION [PR#5899 > development/9.0] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5904

Merged

bert-e mentioned this pull request Aug 12, 2025

INTEGRATION [PR#5899 > development/9.1] CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5905

Merged

bert-e merged commit 8ed743d into development/7.70 Aug 12, 2025
18 checks passed

bert-e deleted the bugfix/CLDSRV-729-remove-md5-header-requirement branch August 12, 2025 15:32

leif-scality mentioned this pull request Sep 3, 2025

CLDSRV-729: don't require content-md5 header in put-bucket-cors and d… #5930

Merged

Conversation

leif-scality commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Aug 8, 2025

Hello leif-scality,

Uh oh!

bert-e commented Aug 8, 2025

Incorrect fix version

Uh oh!

codecov bot commented Aug 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Aug 12, 2025

Branches have diverged

Uh oh!

bert-e commented Aug 12, 2025

Incorrect fix version

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Incorrect fix version

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Request integration branches

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Conflict

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Integration data created

Uh oh!

bert-e commented Aug 12, 2025

Waiting for approval

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Integration data created

Uh oh!

bert-e commented Aug 12, 2025

Waiting for approval

Uh oh!

bert-e commented Aug 12, 2025

Conflict

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Integration data created

Uh oh!

bert-e commented Aug 12, 2025

Waiting for approval

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

leif-scality commented Aug 12, 2025

Uh oh!

bert-e commented Aug 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leif-scality commented Aug 8, 2025 •

edited

Loading

codecov bot commented Aug 8, 2025 •

edited

Loading