Skip to content

CLDSRV-735: Fix DEP0005: Buffer() constructor#5923

Merged
bert-e merged 2 commits intodevelopment/9.0from
bugfix/CLDSRV-735-deprecation-buffer
Aug 29, 2025
Merged

CLDSRV-735: Fix DEP0005: Buffer() constructor#5923
bert-e merged 2 commits intodevelopment/9.0from
bugfix/CLDSRV-735-deprecation-buffer

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

Files Modified:

  1. Production Code:
  • lib/api/apiUtils/object/createAndStoreObject.js - Fixed 1 critical instance in MD5 checksum handling
  1. Test Files:
  • tests/multipleBackend/routes/routeBackbeat.js - Fixed 27 instances
  • tests/multipleBackend/routes/routeBackbeatForReplication.js - Fixed 9 instances
  • tests/unit/management/testChannelMessageV0.js - Fixed 3 instances

Changes Made:

All deprecated constructors were replaced with the secure Buffer.from() method

Fixed critical security vulnerability - new Buffer() could expose uninitialized memory

  Files Modified:

  1. Production Code:
  - lib/api/apiUtils/object/createAndStoreObject.js - Fixed 1 critical instance in MD5 checksum handling

  2. Test Files:
  - tests/multipleBackend/routes/routeBackbeat.js - Fixed 27 instances
  - tests/multipleBackend/routes/routeBackbeatForReplication.js - Fixed 9 instances
  - tests/unit/management/testChannelMessageV0.js - Fixed 3 instances

  Changes Made:

  All deprecated constructors were replaced with the secure Buffer.from() method

  Fixed critical security vulnerability - new Buffer() could expose uninitialized memory
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 29, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 29, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-735 contains:

  • 9.0.25

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.0.25

  • 9.1.0

Please check the Fix Version/s of CLDSRV-735, or the target
branch of this pull request.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
20732 4 20728 0
View the top 2 failed test(s) by shortest run time
"after each" hook for "should replicate/put a lifecycled NULL metadata to a destination that has a version"::backbeat routes for replication (cross account) "after each" hook for "should replicate/put a lifecycled NULL metadata to a destination that has a version"
Stack Traces | 0.053s run time
The bucket you tried to delete is not empty.
"after each" hook for "should replicate/put NULL metadata to a destination that has a version"::backbeat routes for replication (same account) "after each" hook for "should replicate/put NULL metadata to a destination that has a version"
Stack Traces | 0.061s run time
The bucket you tried to delete is not empty.
View the full list of 1 ❄️ flaky tests
should not corrupt object if overwriting an existing part by copying a part while the MPU is being completed::Object Part Copy With default signature When copy source was put by MPU should not corrupt object if overwriting an existing part by copying a part while the MPU is being completed

Flake rate in main: 12.12% (Passed 58 times, Failed 8 times)

Stack Traces | 0.025s run time
We encountered an internal error. Please try again.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@BourgoisMickael BourgoisMickael requested review from a team, benzekrimaha, davidtencer, jonathan-gramain, leif-scality, tcarmet and tmacro and removed request for a team August 29, 2025 18:21
@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/approve

@scality scality deleted a comment from bert-e Aug 29, 2025
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 29, 2025

Conflict

A conflict has been raised during the creation of
integration branch w/9.1/bugfix/CLDSRV-735-deprecation-buffer with contents from bugfix/CLDSRV-735-deprecation-buffer
and development/9.1.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 $ git fetch
 $ git checkout -B w/9.1/bugfix/CLDSRV-735-deprecation-buffer origin/development/9.1
 $ git merge origin/bugfix/CLDSRV-735-deprecation-buffer
 $ # <intense conflict resolution>
 $ git commit
 $ git push -u origin w/9.1/bugfix/CLDSRV-735-deprecation-buffer

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 29, 2025

Build failed

The build for commit did not succeed in branch bugfix/CLDSRV-735-deprecation-buffer

The following options are set: approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Aug 29, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.0

  • ✔️ development/9.1

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8

Please check the status of the associated issue CLDSRV-735.

Goodbye bourgoismickael.

The following options are set: approve

@bert-e bert-e merged commit 15c233b into development/9.0 Aug 29, 2025
107 of 112 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-735-deprecation-buffer branch August 29, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants