CLDSRV-740: Add healthcheck internal route s3 port#5929
CLDSRV-740: Add healthcheck internal route s3 port#5929bert-e merged 6 commits intodevelopment/9.0from
Conversation
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
@@ Coverage Diff @@
## development/9.0 #5929 +/- ##
===================================================
- Coverage 83.19% 83.16% -0.04%
===================================================
Files 188 188
Lines 12095 12103 +8
===================================================
+ Hits 10063 10065 +2
- Misses 2032 2038 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for internal healthcheck routing on the S3 port to enable nginx upstream failover functionality. The implementation allows the healthcheck endpoint to be accessible on the same port as the S3 service when the S3_INTERNAL_HEALTHCHECK environment variable is set.
- Conditionally adds healthcheck handler to internal handlers based on environment variable
- Extends deep healthcheck logic to support internal route
/_/healthcheck/deep
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/utilities/internalHandlers.js | Adds conditional healthcheck handler registration and imports healthcheckHandler |
| lib/utilities/healthcheckHandler.js | Extends deep healthcheck condition to support internal route when S3_INTERNAL_HEALTHCHECK is enabled |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3a6643e to
e2433f9
Compare
Remove warning ``` warning package.json: No license field ```
d05a991 to
20aa021
Compare
20aa021 to
8dbaa91
Compare
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/9.1/improvement/CLDSRV-740-healthcheck-S3C origin/development/9.1
git merge origin/improvement/CLDSRV-740-healthcheck-S3C
# <intense conflict resolution>
git commit
git push -u origin w/9.1/improvement/CLDSRV-740-healthcheck-S3CThe following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-740. Goodbye bourgoismickael. |
Bring back the healthcheck route like it was in development/7.70
needed by S3C s3-frontend