CLDSRV-796: Handle redis unavailability for rate limit

[tmacro]

No description provided.

[bert-e]

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov]

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.34%. Comparing base (d68cae3) to head (c8fe018).
⚠️ Report is 5 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/apiUtils/rateLimit/tokenBucket.js	0.00%	4 Missing ⚠️
lib/api/apiUtils/rateLimit/client.js	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/bucketPutRateLimit.js	100.00% <ø> (+2.43%)	⬆️
lib/server.js	79.10% <100.00%> (ø)
lib/api/apiUtils/rateLimit/client.js	52.94% <0.00%> (-3.31%)	⬇️
lib/api/apiUtils/rateLimit/tokenBucket.js	78.40% <0.00%> (-2.77%)	⬇️

@@                 Coverage Diff                 @@
##           development/9.2    #6031      +/-   ##
===================================================
- Coverage            84.36%   84.34%   -0.02%     
===================================================
  Files                  204      204              
  Lines                12922    12926       +4     
===================================================
+ Hits                 10902    10903       +1     
- Misses                2020     2023       +3     

Flag	Coverage Δ
file-ft-tests	67.43% <28.57%> (-0.02%)	⬇️
kmip-ft-tests	28.15% <28.57%> (-0.01%)	⬇️
mongo-v0-ft-tests	68.69% <28.57%> (-0.02%)	⬇️
mongo-v1-ft-tests	68.68% <28.57%> (-0.02%)	⬇️
multiple-backend	35.32% <28.57%> (-0.02%)	⬇️
sur-tests	35.64% <28.57%> (-0.05%)	⬇️
sur-tests-inflights	37.49% <28.57%> (+0.01%)	⬆️
unit	69.92% <0.00%> (-0.03%)	⬇️
utapi-v2-tests	34.34% <28.57%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[anurag4DSB]

we should also log the bucket name here

[anurag4DSB]

should we also add to default fields, rateLimited: false or something, like we do when we rate limit

like this: https://github.com/scality/cloudserver/blob/development/9.2/lib/api/api.js#L386

[tmacro]

I added the bucket name. I don't think the rateLimited field makes sense here as we're not making accept/deny decisions.

[tmacro]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.2

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1

Please check the status of the associated issue CLDSRV-796.

Goodbye tmacro.

The following options are set: approve