CLDSRV-839: Reduce warning, add cors preflight, rename website#6065
CLDSRV-839: Reduce warning, add cors preflight, rename website#6065bert-e merged 5 commits intodevelopment/9.2from
Conversation
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.2 #6065 +/- ##
================================================
Coverage 84.48% 84.49%
================================================
Files 206 206
Lines 13137 13142 +5
================================================
+ Hits 11099 11104 +5
Misses 2038 2038
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5126f88 to
917732f
Compare
Some Integration / Functional tests emit warning for cors - apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester/testobject - apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester/anotherObjectKey - apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester
Every other places we use number type, nodejs takes care of stringifying. For byteSent in server access logs we expect number type
S3 can receive many invalid requests, from internet scraper or other things. We don't want to warn for a request we can't process. Example warnings from lab / tests - apiMethod=undefined, method=OPTIONS, url=/bucketcorstester - apiMethod=undefined, method=POST, url=/ - apiMethod=undefined, method=DELETE, url=/bucketA - apiMethod=undefined, method=PUT, url=/as - apiMethod=undefined, method=PUT, url=/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx - apiMethod=undefined, method=PUT, url=/192.168.5.4 - apiMethod=undefined, method=PUT, url=/.myawsbucket - apiMethod=undefined, method=PUT, url=/myawsbucket. - apiMethod=undefined, method=PUT, url=/my..examplebucket - apiMethod=undefined, method=PUT, url=/my.%23s3bucket
917732f to
14627b8
Compare
From REST.*.WEBSITE => WEBSITE.*.OBJECT
8bd9b9f to
a8f32a3
Compare
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: git fetch
git checkout -B w/9.3/bugfix/CLDSRV-839-fix-logs-operation origin/development/9.3
git merge origin/bugfix/CLDSRV-839-fix-logs-operation
# <intense conflict resolution>
git commit
git push -u origin w/9.3/bugfix/CLDSRV-839-fix-logs-operationThe following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/approve |
Build failedThe build for commit did not succeed in branch w/9.3/bugfix/CLDSRV-839-fix-logs-operation The following options are set: approve, create_integration_branches |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-839. Goodbye bourgoismickael. The following options are set: approve, create_integration_branches |
see commits
Not simple to have tests running on those because they are http request outside the SDK.
It seems that website and corsPreflight requests have no
analyticsActionname (no monitoring action), they might leave an empty action in S3 monitoring