Skip to content

CLDSRV-839: Reduce warning, add cors preflight, rename website#6065

Merged
bert-e merged 5 commits intodevelopment/9.2from
bugfix/CLDSRV-839-fix-logs-operation
Jan 29, 2026
Merged

CLDSRV-839: Reduce warning, add cors preflight, rename website#6065
bert-e merged 5 commits intodevelopment/9.2from
bugfix/CLDSRV-839-fix-logs-operation

Conversation

@BourgoisMickael
Copy link
Copy Markdown
Contributor

@BourgoisMickael BourgoisMickael commented Jan 28, 2026

see commits

Not simple to have tests running on those because they are http request outside the SDK.

It seems that website and corsPreflight requests have no analyticsAction name (no monitoring action), they might leave an empty action in S3 monitoring

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 28, 2026

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 28, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.49%. Comparing base (44624d5) to head (a8f32a3).
⚠️ Report is 5 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/object/corsResponse.js 100.00% <100.00%> (ø)
lib/utilities/serverAccessLogger.js 81.85% <100.00%> (+0.41%) ⬆️
@@               Coverage Diff                @@
##           development/9.2    #6065   +/-   ##
================================================
  Coverage            84.48%   84.49%           
================================================
  Files                  206      206           
  Lines                13137    13142    +5     
================================================
+ Hits                 11099    11104    +5     
  Misses                2038     2038           
Flag Coverage Δ
file-ft-tests 67.68% <100.00%> (+0.01%) ⬆️
kmip-ft-tests 28.25% <28.57%> (+<0.01%) ⬆️
mongo-v0-ft-tests 68.92% <100.00%> (+0.01%) ⬆️
mongo-v1-ft-tests 68.91% <100.00%> (-0.02%) ⬇️
multiple-backend 35.23% <28.57%> (+<0.01%) ⬆️
sur-tests 35.81% <28.57%> (+0.03%) ⬆️
sur-tests-inflights 37.66% <28.57%> (+0.03%) ⬆️
unit 69.64% <57.14%> (-0.01%) ⬇️
utapi-v2-tests 34.49% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael BourgoisMickael force-pushed the bugfix/CLDSRV-839-fix-logs-operation branch 7 times, most recently from 5126f88 to 917732f Compare January 28, 2026 22:32
Some Integration / Functional tests emit warning for cors

- apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester/testobject
- apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester/anotherObjectKey
- apiMethod=corsPreflight, method=OPTIONS, url=/bucketcorstester
Every other places we use number type, nodejs takes care of stringifying.

For byteSent in server access logs we expect number type
S3 can receive many invalid requests, from internet scraper or other things.
We don't want to warn for a request we can't process.

Example warnings from lab / tests
- apiMethod=undefined, method=OPTIONS, url=/bucketcorstester
- apiMethod=undefined, method=POST, url=/
- apiMethod=undefined, method=DELETE, url=/bucketA
- apiMethod=undefined, method=PUT, url=/as
- apiMethod=undefined, method=PUT, url=/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
- apiMethod=undefined, method=PUT, url=/192.168.5.4
- apiMethod=undefined, method=PUT, url=/.myawsbucket
- apiMethod=undefined, method=PUT, url=/myawsbucket.
- apiMethod=undefined, method=PUT, url=/my..examplebucket
- apiMethod=undefined, method=PUT, url=/my.%23s3bucket
@BourgoisMickael BourgoisMickael force-pushed the bugfix/CLDSRV-839-fix-logs-operation branch from 917732f to 14627b8 Compare January 28, 2026 22:46
@BourgoisMickael BourgoisMickael force-pushed the bugfix/CLDSRV-839-fix-logs-operation branch from 8bd9b9f to a8f32a3 Compare January 28, 2026 22:48
@BourgoisMickael BourgoisMickael changed the title CLDSRV-839: Add PREFLIGHT logs and reduce warnings CLDSRV-839: Reduce warning, add cors preflight, rename website Jan 28, 2026
@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 28, 2026

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/bugfix/CLDSRV-839-fix-logs-operation with contents from bugfix/CLDSRV-839-fix-logs-operation
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/bugfix/CLDSRV-839-fix-logs-operation origin/development/9.3
 git merge origin/bugfix/CLDSRV-839-fix-logs-operation
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/bugfix/CLDSRV-839-fix-logs-operation

The following options are set: create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 28, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@BourgoisMickael
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 29, 2026

Build failed

The build for commit did not succeed in branch w/9.3/bugfix/CLDSRV-839-fix-logs-operation

The following options are set: approve, create_integration_branches

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Jan 29, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.2

  • ✔️ development/9.3

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1

Please check the status of the associated issue CLDSRV-839.

Goodbye bourgoismickael.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit a8f32a3 into development/9.2 Jan 29, 2026
29 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-839-fix-logs-operation branch January 29, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants