👷(CLDSRV-867) Clean old GCP bucket by DarkIsDude · Pull Request #6098 · scality/cloudserver

DarkIsDude · 2026-03-09T16:37:01Z

Pull request template

Description

Motivation and context

Clean GCP bucket older than one week - stuck from the CI and will never be removed.

Add the GITHUB Action ID in the bucket name to be able to identify the root cause.

bert-e · 2026-03-09T16:37:05Z

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-03-09T16:37:11Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

codecov · 2026-03-09T16:42:01Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
8224	1	8223	0

View the full list of 1 ❄️ flaky test(s)

"before all" hook for "should delete a object uploaded in parts successfully"::DELETE object With default signature with multipart upload "before all" hook for "should delete a object uploaded in parts successfully"

Flake rate in main: 100.00% (Passed 0 times, Failed 50 times)

Stack Traces | 0.173s run time

socket hang up

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

lib/api/objectGetAttributes.js

lib/api/bucketGet.js

lib/routes/routeBackbeat.js

lib/api/objectGetLegalHold.js

lib/api/bucketGet.js

lib/api/objectGetLegalHold.js

claude · 2026-03-09T16:44:16Z

Review summary: objectGetAttributes.js:119 Mutating singleton error objects pollutes shared state across requests, leaking CORS headers. Same issue at line 135. Clone the error before setting .responseHeaders. | bucketGet.js:158 Stray trailing comma after buildAttributesXml() creates a comma expression. Replace with semicolon. | routeBackbeat.js:728 errorMessage.includes repair is too broad. Remove it, keep only E11000 and duplicate key checks. | objectGetLegalHold.js:106 module.exports wrapper duplicates inner callback bridge (lines 20-25), making inner bridge dead code. Pick one pattern. | bucketGet.js:362 and objectGetLegalHold.js:51 promisify called on every request. Hoist to module level. -- Review by Claude Code

bert-e · 2026-03-09T16:49:07Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-867 contains:

9.2.30
9.3.5
9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.5
9.4.0

Please check the Fix Version/s of CLDSRV-867, or the target
branch of this pull request.

bert-e · 2026-03-09T16:51:12Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

claude · 2026-03-10T10:39:19Z

LGTM

Review by Claude Code

claude · 2026-03-10T11:07:30Z

tests/functional/raw-node/utils/gcpUtils.js

-const genUniqID = () => uuidv4().replace(/-/g, '');
+const genUniqID = () => {
+    const runId = process.env.GITHUB_RUN_ID;
+    const suffix = uuidv4().replace(/-/g, '').slice(0, 8);


When GITHUB_RUN_ID is set, genUniqID produces only 8 hex characters of randomness (uuidv4().slice(0, 8)). Multiple test files call genBucketName at module-load time with the same testName within the same CI run, so the only uniqueness comes from those 8 chars. While ~4 billion values makes collisions very unlikely in practice, the previous code used the full 32-char UUID. Consider using a longer slice (e.g. 12-16 chars) to keep the same safety margin while still including the run ID.

— Claude Code

claude · 2026-03-10T11:07:36Z

LGTM — clean PR that adds a GCP bucket cleanup job and improves bucket naming for traceability. One minor note:

- genUniqID truncates UUID to 8 chars when GITHUB_RUN_ID is set, reducing randomness from 32 to 8 hex chars. Unlikely to cause issues in practice but could use a longer slice for extra safety.

Review by Claude Code

bert-e · 2026-03-11T13:10:23Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-867 contains:

9.3.5
9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.3.6
9.4.0

Please check the Fix Version/s of CLDSRV-867, or the target
branch of this pull request.

Issue: CLDSRV-867

bert-e · 2026-03-17T10:29:38Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

claude · 2026-03-17T10:30:48Z

LGTM

Review by Claude Code

Issue: CLDSRV-867

claude · 2026-03-17T13:33:12Z

LGTM

Review by Claude Code

DarkIsDude · 2026-03-17T14:16:38Z

/approve

bert-e · 2026-03-17T14:16:52Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/CLDSRV-867/clean-gcp-bucket into
development/9.3
w/9.4/feature/CLDSRV-867/clean-gcp-bucket will be merged into development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2026-03-17T14:39:55Z

Build failed

The build for commit did not succeed in branch w/9.4/feature/CLDSRV-867/clean-gcp-bucket

The following options are set: approve

bert-e · 2026-03-17T15:28:10Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Please check the status of the associated issue CLDSRV-867.

Goodbye darkisdude.

The following options are set: approve

DarkIsDude self-assigned this Mar 9, 2026