add missing header for put encrypted object by SylvainSenechal · Pull Request #6122 · scality/cloudserver

SylvainSenechal · 2026-03-30T13:34:54Z

Kinda need it because imma add functional tests in zenko, and these tests will depend on this

bert-e · 2026-03-30T13:34:58Z

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-03-30T13:35:04Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

claude · 2026-03-30T13:36:28Z

LGTM

Review by Claude Code

codecov · 2026-03-30T13:40:11Z

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (686200b) to head (54bd02e).
⚠️ Report is 1 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/objectPut.js	80.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/objectPut.js	`94.21% <80.00%> (-0.62%)`	⬇️

... and 4 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6122      +/-   ##
===================================================
- Coverage            84.31%   84.26%   -0.06%     
===================================================
  Files                  206      206              
  Lines                13251    13256       +5     
===================================================
- Hits                 11173    11170       -3     
- Misses                2078     2086       +8

Flag	Coverage Δ
file-ft-tests	`67.93% <80.00%> (-0.05%)`	⬇️
kmip-ft-tests	`28.10% <80.00%> (+0.01%)`	⬆️
mongo-v0-ft-tests	`69.12% <80.00%> (-0.05%)`	⬇️
mongo-v1-ft-tests	`69.13% <80.00%> (-0.02%)`	⬇️
multiple-backend	`36.30% <20.00%> (-0.01%)`	⬇️
sur-tests	`36.45% <20.00%> (-0.01%)`	⬇️
sur-tests-inflights	`37.51% <20.00%> (+0.02%)`	⬆️
unit	`69.88% <20.00%> (-0.02%)`	⬇️
utapi-v2-tests	`34.39% <20.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR addresses CLDSRV-879 by ensuring PUT Object responses include the expected server-side encryption (SSE) headers when an object is stored with encryption (either explicitly requested or applied via bucket default encryption).

Changes:

Add SSE response headers to objectPut responses using the shared setSSEHeaders helper once the cipher bundle is created.
Extend functional tests to assert PutObject responses include ServerSideEncryption (and SSEKMSKeyId for aws:kms) in relevant scenarios.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/functional/aws-node-sdk/test/object/encryptionHeaders.js	Adds assertions verifying `PutObject` responses include SSE-related response headers.
lib/api/objectPut.js	Sets SSE response headers for PUT responses based on the selected encryption config/cipher bundle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SylvainSenechal · 2026-03-30T15:47:14Z

/create_integration_branches

bert-e · 2026-03-30T15:47:25Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-879 into
development/9.3
w/9.4/bugfix/CLDSRV-879 will be merged into development/9.4

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2026-03-30T15:47:26Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

SylvainSenechal · 2026-03-30T15:47:56Z

/approve

bert-e · 2026-03-30T16:11:56Z

Build failed

The build for commit did not succeed in branch w/9.4/bugfix/CLDSRV-879

The following options are set: approve, create_integration_branches

bert-e · 2026-03-31T08:21:30Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2

Please check the status of the associated issue CLDSRV-879.

Goodbye sylvainsenechal.

The following options are set: approve, create_integration_branches

add missing header for put encrypted object

54bd02e

Issue: CLDSRV-879

SylvainSenechal requested review from a team, BourgoisMickael, DarkIsDude, Copilot and delthas March 30, 2026 14:24

Copilot started reviewing on behalf of SylvainSenechal March 30, 2026 14:25 View session

SylvainSenechal marked this pull request as ready for review March 30, 2026 14:25

Copilot AI reviewed Mar 30, 2026

View reviewed changes

BourgoisMickael approved these changes Mar 30, 2026

View reviewed changes

DarkIsDude approved these changes Mar 30, 2026

View reviewed changes

bert-e merged commit 54bd02e into development/9.3 Mar 31, 2026
35 checks passed

bert-e deleted the bugfix/CLDSRV-879 branch March 31, 2026 08:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add missing header for put encrypted object#6122

add missing header for put encrypted object#6122
bert-e merged 1 commit intodevelopment/9.3from
bugfix/CLDSRV-879

SylvainSenechal commented Mar 30, 2026 •

edited

Loading

Uh oh!

bert-e commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Uh oh!

claude bot commented Mar 30, 2026

Uh oh!

codecov bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

SylvainSenechal commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Uh oh!

SylvainSenechal commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Uh oh!

bert-e commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

SylvainSenechal commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Mar 30, 2026

Hello sylvainsenechal,

Uh oh!

bert-e commented Mar 30, 2026

Request integration branches

Uh oh!

claude bot commented Mar 30, 2026

Uh oh!

codecov bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

SylvainSenechal commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Integration data created

Uh oh!

bert-e commented Mar 30, 2026

Waiting for approval

Uh oh!

SylvainSenechal commented Mar 30, 2026

Uh oh!

bert-e commented Mar 30, 2026

Build failed

Uh oh!

bert-e commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SylvainSenechal commented Mar 30, 2026 •

edited

Loading

codecov bot commented Mar 30, 2026 •

edited

Loading