Skip to content

CLDSRV-883: CreateMultipartUpload parse checksum headers and store them in MPU overview object#6144

Open
leif-scality wants to merge 1 commit intodevelopment/9.4from
improvement/CLDSRV-883-create-mpu-handle-checksum
Open

CLDSRV-883: CreateMultipartUpload parse checksum headers and store them in MPU overview object#6144
leif-scality wants to merge 1 commit intodevelopment/9.4from
improvement/CLDSRV-883-create-mpu-handle-checksum

Conversation

@leif-scality
Copy link
Copy Markdown
Contributor

@leif-scality leif-scality commented Apr 9, 2026

  • Stores the checksum algo and type of an MPU created via CreateMultipartUpload
  • Defaults to CRC64NVME FULL_OBJECT if checksum header is sent
  • The stored checksum algo and type needs to be returned by ListMultipartUploads, to be added in https://scality.atlassian.net/browse/S3C-11109

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 9, 2026

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 9, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-883 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of CLDSRV-883, or the target
branch of this pull request.

@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

LGTM

Review by Claude Code

@leif-scality leif-scality force-pushed the improvement/CLDSRV-883-create-mpu-handle-checksum branch from 401021f to 21a51aa Compare April 9, 2026 17:54
@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

LGTM

Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.90%. Comparing base (09256e2) to head (68227d0).
⚠️ Report is 13 commits behind head on development/9.4.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/initiateMultipartUpload.js 79.41% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/integrity/validateChecksums.js 98.98% <100.00%> (+0.18%) ⬆️
lib/services.js 87.17% <100.00%> (+0.10%) ⬆️
lib/api/initiateMultipartUpload.js 91.27% <79.41%> (+0.71%) ⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6144      +/-   ##
===================================================
+ Coverage            84.84%   84.90%   +0.05%     
===================================================
  Files                  207      207              
  Lines                13613    13659      +46     
===================================================
+ Hits                 11550    11597      +47     
+ Misses                2063     2062       -1     
Flag Coverage Δ
file-ft-tests 68.73% <72.05%> (+0.06%) ⬆️
kmip-ft-tests 28.15% <44.11%> (+0.05%) ⬆️
mongo-v0-ft-tests 69.90% <72.05%> (+0.05%) ⬆️
mongo-v1-ft-tests 69.99% <72.05%> (+0.15%) ⬆️
multiple-backend 36.41% <13.23%> (-0.07%) ⬇️
sur-tests 36.35% <44.11%> (+0.83%) ⬆️
sur-tests-inflights 37.35% <44.11%> (-0.01%) ⬇️
unit 71.30% <89.70%> (+0.09%) ⬆️
utapi-v2-tests 34.51% <44.11%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@leif-scality leif-scality force-pushed the improvement/CLDSRV-883-create-mpu-handle-checksum branch from 21a51aa to 68227d0 Compare April 9, 2026 18:16
@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

LGTM

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants