Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/utilities/serverAccessLogger.js
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,16 @@ function getOperation(req) {
return `REST.${req.method}.${resourceType}`;
}

const assumedRoleArnRegex = /^arn:aws:sts::[0-9]{12}:assumed-role\/\S+$/;

function getRequester(authInfo) {
const requester = null;
if (authInfo) {
const arn = authInfo.getArn ? authInfo.getArn() : null;
if (authInfo.isRequesterPublicUser && authInfo.isRequesterPublicUser()) {
return requester; // Unauthenticated requests
} else if (arn && assumedRoleArnRegex.test(arn)) {
return arn;
} else if (authInfo.isRequesterAnIAMUser && authInfo.isRequesterAnIAMUser()) {
// IAM user: include IAM user name and account
const iamUserName = authInfo.getIAMdisplayName ? authInfo.getIAMdisplayName() : '';
Expand Down
25 changes: 25 additions & 0 deletions tests/unit/utils/serverAccessLogger.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,31 @@ describe('serverAccessLogger utility functions', () => {
assert.strictEqual(result, 'canonicalID123');
});

it('should return ARN for assumed-role session user', () => {
const arn = 'arn:aws:sts::123456789012:assumed-role/lifecycle-role/backbeat-lifecycle';
const authInfo = {
isRequesterPublicUser: () => false,
isRequesterAnIAMUser: () => false,
getArn: () => arn,
getCanonicalID: () => 'canonicalID789',
};
const result = getRequester(authInfo);
assert.strictEqual(result, arn);
});
Comment thread
dvasilas marked this conversation as resolved.

it('should fall through to IAM user path for non-assumed-role ARN', () => {
const authInfo = {
isRequesterPublicUser: () => false,
isRequesterAnIAMUser: () => true,
getArn: () => 'arn:aws:iam::123456789012:user/myuser',
getIAMdisplayName: () => 'myuser',
getAccountDisplayName: () => 'myaccount',
getCanonicalID: () => 'canonicalID789',
};
const result = getRequester(authInfo);
assert.strictEqual(result, 'myuser:myaccount');
});

it('should return canonical ID for regular user', () => {
const authInfo = {
isRequesterPublicUser: () => false,
Expand Down
Loading