LOGC-57: Close GetObject response bodies in e2e tests

Author: dvasilas

test/e2e/acl_required_test.go

@@ -34,11 +34,12 @@ var _ = Describe("aclRequired field in access logs", func() {
 		})
 		Expect(err).NotTo(HaveOccurred(), "PUT should succeed")
 
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		resp, err := testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET should succeed")
+		_ = resp.Body.Close()
 
 		testCtx.VerifyLogs(
 			testCtx.ObjectOp("REST.PUT.OBJECT", testKey, 200).
@@ -79,11 +80,12 @@ var _ = Describe("aclRequired field in access logs", func() {
 		// GET object as the IAM user — authorized via ACL (same account)
 		iamS3Client := iamUser.S3Client
 
-		_, err = iamS3Client.GetObject(ctx, &s3.GetObjectInput{
+		resp, err := iamS3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET as IAM user should succeed")
+		_ = resp.Body.Close()
 
 		logs := testCtx.VerifyLogs(
 			testCtx.ObjectOp("REST.PUT.OBJECT", testKey, 200).

test/e2e/object_operations_test.go

@@ -34,11 +34,12 @@ var _ = Describe("Object Operations", func() {
 		})
 		Expect(err).NotTo(HaveOccurred(), "PUT operation should succeed")
 
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		getResp, err := testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET operation should succeed")
+		_ = getResp.Body.Close()
 
 		_, err = testCtx.S3Client.HeadObject(ctx, &s3.HeadObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
@@ -239,30 +240,33 @@ var _ = Describe("Object Operations", func() {
 
 		// Range GET - first 10 bytes
 		rangeHeader := "bytes=0-9"
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		rangeResp, err := testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 			Range:  aws.String(rangeHeader),
 		})
 		Expect(err).NotTo(HaveOccurred(), "Range GET should succeed")
+		_ = rangeResp.Body.Close()
 
 		// Range GET - last 5 bytes
 		rangeHeader2 := "bytes=-5"
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		rangeResp, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 			Range:  aws.String(rangeHeader2),
 		})
 		Expect(err).NotTo(HaveOccurred(), "Range GET (suffix) should succeed")
+		_ = rangeResp.Body.Close()
 
 		// Range GET - middle portion (bytes 5-14)
 		rangeHeader3 := "bytes=5-14"
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		rangeResp, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 			Range:  aws.String(rangeHeader3),
 		})
 		Expect(err).NotTo(HaveOccurred(), "Range GET (middle) should succeed")
+		_ = rangeResp.Body.Close()
 
 		// invalid range (beyond object size)
 		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
@@ -309,11 +313,12 @@ var _ = Describe("Object Operations", func() {
 		})
 		Expect(err).NotTo(HaveOccurred(), "PUT empty object should succeed")
 
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		getResp, err := testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET empty object should succeed")
+		_ = getResp.Body.Close()
 
 		_, err = testCtx.S3Client.HeadObject(ctx, &s3.HeadObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
@@ -437,12 +442,13 @@ var _ = Describe("Object Operations", func() {
 		deleteMarkerVersionID := deleteResp.VersionId
 
 		// GET object WITH ?versionId= (should log the versionId)
-		_, err = testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
+		getResp, err := testCtx.S3Client.GetObject(ctx, &s3.GetObjectInput{
 			Bucket:    aws.String(testCtx.SourceBucket),
 			Key:       aws.String(testKey),
 			VersionId: versionID,
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET object version should succeed")
+		_ = getResp.Body.Close()
 
 		// HEAD object WITH ?versionId= (should log the versionId)
 		_, err = testCtx.S3Client.HeadObject(ctx, &s3.HeadObjectInput{

test/e2e/tls_fields_test.go

@@ -84,11 +84,12 @@ var _ = Describe("TLS fields in access logs", func() {
 		})
 		Expect(err).NotTo(HaveOccurred(), "PUT through S3 frontend should succeed")
 
-		_, err = tlsClient.GetObject(ctx, &s3.GetObjectInput{
+		getResp, err := tlsClient.GetObject(ctx, &s3.GetObjectInput{
 			Bucket: aws.String(testCtx.SourceBucket),
 			Key:    aws.String(testKey),
 		})
 		Expect(err).NotTo(HaveOccurred(), "GET through S3 frontend should succeed")
+		_ = getResp.Body.Close()
 
 		logs := testCtx.VerifyLogs(
 			testCtx.ObjectOp("REST.PUT.OBJECT", testKey, 200).WithObjectSize(int64(len(testContent))),