LOGC-57: Add e2e tests for aclRequired field#143
Merged
Conversation
Review by Claude Code |
|
LGTM Clean PR: the IAM helper extraction is well-done, the new tests cover the key aclRequired scenarios, and the GetObject Body.Close() fixes are good hygiene. One minor note posted inline about the CloudServer image pin. Review by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 22 22
Lines 1942 1942
=======================================
Hits 1485 1485
Misses 366 366
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
nicolas2bert
approved these changes
Apr 8, 2026
leif-scality
approved these changes
Apr 9, 2026
fredmnl
approved these changes
Apr 9, 2026
c4c9440 to
c9c78fe
Compare
|
LGTM Clean refactoring of IAM user creation into a shared createIAMUser helper, good new test coverage for the aclRequired field, and useful fixes closing previously-leaked response bodies. Review by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end-to-end tests validating that the
aclRequiredfield appears correctly in delivered server access logs.Cloudserver PR: scality/cloudserver#6142