Skip to content

LOGC-57: Add e2e tests for aclRequired field#143

Merged
dvasilas merged 4 commits into
mainfrom
improvement/LOGC-57-acl-required-e2e-tests
Apr 9, 2026
Merged

LOGC-57: Add e2e tests for aclRequired field#143
dvasilas merged 4 commits into
mainfrom
improvement/LOGC-57-acl-required-e2e-tests

Conversation

@dvasilas
Copy link
Copy Markdown
Collaborator

@dvasilas dvasilas commented Apr 8, 2026

Add end-to-end tests validating that the aclRequired field appears correctly in delivered server access logs.

Cloudserver PR: scality/cloudserver#6142

Comment thread test/e2e/acl_required_test.go
Comment thread test/e2e/acl_required_test.go
@claude
Copy link
Copy Markdown

claude Bot commented Apr 8, 2026

  • Successful GetObject responses in acl_required_test.go (lines 37-41 and 82-86) discard the response without closing the body, leaking HTTP connections.
    • Capture the response and close the body after the error check.

Review by Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented Apr 8, 2026

LGTM

Clean PR: the IAM helper extraction is well-done, the new tests cover the key aclRequired scenarios, and the GetObject Body.Close() fixes are good hygiene.

One minor note posted inline about the CloudServer image pin.

Review by Claude Code

Comment thread env/default/values.yaml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.46%. Comparing base (62d4ffc) to head (c9c78fe).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files          22       22           
  Lines        1942     1942           
=======================================
  Hits         1485     1485           
  Misses        366      366           
  Partials       91       91           
Flag Coverage Δ
unit 76.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dvasilas dvasilas force-pushed the improvement/LOGC-57-acl-required-e2e-tests branch from c4c9440 to c9c78fe Compare April 9, 2026 10:52
@claude
Copy link
Copy Markdown

claude Bot commented Apr 9, 2026

LGTM

Clean refactoring of IAM user creation into a shared createIAMUser helper, good new test coverage for the aclRequired field, and useful fixes closing previously-leaked response bodies.

Review by Claude Code

@dvasilas dvasilas merged commit c6a33e3 into main Apr 9, 2026
6 checks passed
@dvasilas dvasilas deleted the improvement/LOGC-57-acl-required-e2e-tests branch April 9, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants