-
Notifications
You must be signed in to change notification settings - Fork 3
feat(SP-2487): Implement path obfuscation #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b4423ae
chore(SP-2487): add utils `extractFilePathsFromWFPBlock()` and `extra…
isasmendiagus b8ec9e7
feat(SP-2487): implement path obfuscation on Winnowing class
isasmendiagus 3e77390
feat(SP-2487): implement path deobfuscation on Scanner class
isasmendiagus 9090987
feat(SP-2487): add obfuscate option to CLI
isasmendiagus 31f0855
chore(SP-2487): add `javadoc` and `lint` to Makefile
isasmendiagus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| /* | ||
| * Copyright (c) 2025, SCANOSS | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in | ||
| * all copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ | ||
| package com.scanoss; | ||
|
|
||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.*; | ||
| import java.util.concurrent.*; | ||
|
|
||
| import static org.junit.Assert.*; | ||
| /** | ||
| * Tests to validate thread safety of the path obfuscation feature in the Winnowing class. | ||
| */ | ||
| @Slf4j | ||
| public class WinnowingConcurrencyTest { | ||
|
|
||
| /** | ||
| * Test that concurrent obfuscation of paths works correctly without data loss or corruption. | ||
| * This simulates multiple threads processing different files simultaneously. | ||
| */ | ||
| @Test | ||
| public void testConcurrentObfuscation() throws InterruptedException, ExecutionException { | ||
| int fileCount = 500; // More files to increase collision chances | ||
| int iterations = 3; // Run multiple iterations to increase stress | ||
|
|
||
|
|
||
| for (int iter = 0; iter < iterations; iter++) { | ||
| log.info("Starting high-collision test iteration {}", iter); | ||
|
|
||
| Winnowing winnowing = Winnowing.builder().obfuscate(true).build(); | ||
|
|
||
| ExecutorService executor = Executors.newFixedThreadPool(fileCount); | ||
|
|
||
| // Create a list of paths to obfuscate | ||
| List<String> paths = new ArrayList<>(); | ||
| for (int i = 0; i < fileCount; i++) { | ||
| paths.add("/path/to/file" + i + ".java"); | ||
| } | ||
|
|
||
| List<Future<String>> futures = new ArrayList<>(fileCount); | ||
|
|
||
| // Use a CyclicBarrier to ensure all threads start exactly together. | ||
| CyclicBarrier barrier = new CyclicBarrier(fileCount, () -> log.info("All threads released simultaneously!")); | ||
|
|
||
| for (String path : paths) { | ||
| futures.add(executor.submit(() -> { | ||
| try { | ||
| byte[] contents = ("sample content for " + path).getBytes(); | ||
|
|
||
| // Wait at barrier until all threads are ready | ||
| barrier.await(); | ||
|
|
||
| // Access the same Winnowing instance concurrently | ||
| return winnowing.wfpForContents(path, false, contents); | ||
|
|
||
| } catch (InterruptedException | BrokenBarrierException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| })); | ||
| } | ||
|
|
||
| // Wait for all tasks to complete | ||
| for (Future<String> future : futures) { | ||
| future.get(); | ||
| } | ||
|
|
||
| executor.shutdown(); | ||
| assertTrue("Executor did not terminate properly", | ||
| executor.awaitTermination(5, TimeUnit.SECONDS)); | ||
|
|
||
| // Verify results | ||
| log.info("Processed {} paths with {} unique results", | ||
| paths.size(), winnowing.getObfuscationMapSize()); | ||
| assertEquals(paths.size(), winnowing.getObfuscationMapSize()); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment right?
should be "If the original path is not found in the obfuscation map, the obfuscated path is returned." ?