Skip to content

Commit c720984

Browse files
committed
fix(linker): add RegionRefiner dependency to Segmentator
segmentator.cpp calls RegionRefiner::refine() and RegionRefiner::group() but never declared a link dependency on VMPilot_SDK_RegionRefiner. GNU ld processes static archives left-to-right and discards unreferenced symbols, so RegionRefiner.a was already consumed before Segmentator.a introduced the undefined references.
1 parent d0be69e commit c720984

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

frontend/src/segmentator/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ include_directories(${INCLUDE_DIRS})
2929

3030
add_library(${TARGER_NAME} STATIC ${SRC_FILES})
3131

32-
target_link_libraries(${TARGER_NAME} PUBLIC VMPilot_Common capstone_wrapper coffi-modern elfio-modern)
32+
target_link_libraries(${TARGER_NAME} PUBLIC VMPilot_Common VMPilot_SDK_RegionRefiner capstone_wrapper coffi-modern elfio-modern)
3333

3434
# Suppress warnings-as-errors from third-party headers (coffi C4754 on MSVC)
3535
include(${CMAKE_SOURCE_DIR}/cmake/SuppressThirdPartyWarnings.cmake)

0 commit comments

Comments
 (0)