Fix cross-platform release build (Linux/Windows) - #174
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 82.95% 82.62% -0.33%
==========================================
Files 19 19
Lines 2435 2435
Branches 412 412
==========================================
- Hits 2020 2012 -8
- Misses 299 308 +9
+ Partials 116 115 -1 🚀 New features to boost your workflow:
|
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release matrix (#167) so the native binaries actually build on Linux and Windows. Validated by dispatching the workflow on this branch: macos-arm64, linux-x64, linux-arm64 and windows-x64 all build and smoke-test green (4 artifacts uploaded). windows-arm64 remains experimental (no MSYS2 gfortran for CLANGARM64; tracked in #173).
Fixes
-l:lblas.a->-l:libblas.a(the-l:syntax needs the full archive filename; Ubuntu shipslibblas.a).build.shusedpython3andcc, which the mingw shell does not provide;build.shnow falls back topython/gcc, and the workflow installsmingw-w64-*-python.Test plan
Dispatched run: 4/5 native targets green, each smoke-tested (2-iteration fit on real sample EEG -> finite negative LL). windows-arm64 fails at toolchain setup only (continue-on-error), tracked in #173.