Skip to content

Fix cross-platform release build (Linux/Windows) - #174

Merged
neuromechanist merged 1 commit into
mainfrom
fix/release-workflow-crossplatform
Jul 17, 2026
Merged

Fix cross-platform release build (Linux/Windows)#174
neuromechanist merged 1 commit into
mainfrom
fix/release-workflow-crossplatform

Conversation

@neuromechanist

Copy link
Copy Markdown
Member

Summary

Fixes the release matrix (#167) so the native binaries actually build on Linux and Windows. Validated by dispatching the workflow on this branch: macos-arm64, linux-x64, linux-arm64 and windows-x64 all build and smoke-test green (4 artifacts uploaded). windows-arm64 remains experimental (no MSYS2 gfortran for CLANGARM64; tracked in #173).

Fixes

  • Linux: -l:lblas.a -> -l:libblas.a (the -l: syntax needs the full archive filename; Ubuntu ships libblas.a).
  • Windows (MSYS2 MINGW64): build.sh used python3 and cc, which the mingw shell does not provide; build.sh now falls back to python/gcc, and the workflow installs mingw-w64-*-python.

Test plan

Dispatched run: 4/5 native targets green, each smoke-tested (2-iteration fit on real sample EEG -> finite negative LL). windows-arm64 fails at toolchain setup only (continue-on-error), tracked in #173.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.62%. Comparing base (c0a5cc3) to head (9acf6b7).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   82.95%   82.62%   -0.33%     
==========================================
  Files          19       19              
  Lines        2435     2435              
  Branches      412      412              
==========================================
- Hits         2020     2012       -8     
- Misses        299      308       +9     
+ Partials      116      115       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neuromechanist
neuromechanist merged commit 85892a2 into main Jul 17, 2026
11 of 12 checks passed
@neuromechanist
neuromechanist deleted the fix/release-workflow-crossplatform branch July 17, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants