chore: bump go to 1.26.3 in gomod (#116)

* chore: bump go to 1.26.3 in gomod

* chore: bump go version in CI and golangci-lint version

* ci: bump go to 1.26.3 in the build/test pipeline

* chore: fix linting issues due to golangci-lint upgrade

Author: dottorblaster

.github/workflows/go.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: actions/setup-go@v6
         with:
-          go-version: '1.25.8'
+          go-version: '1.26.3'
 
       - name: Install dependencies
         run: |
@@ -27,7 +27,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.11.3
+          version: v2.12.2
           args: --build-tags containers_image_openpgp
 
       - name: Check generated manpages are up to date
@@ -53,7 +53,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v6
       with:
-        go-version: '1.25.8'
+        go-version: '1.26.3'
 
     - name: Install dependencies
       run: |

cmd/schedctl/doctor.go

@@ -20,9 +20,9 @@ func NewDoctorCmd() *cli.Command {
 			" Exits non-zero when any blocking check fails.",
 		Flags: []cli.Flag{
 			&cli.StringFlag{
-				Name:     "output",
+				Name:     flagOutput,
 				Aliases:  []string{"o"},
-				Usage:    "output format: text, json",
+				Usage:    flagOutputUsage,
 				Value:    outputText,
 				Local:    true,
 				Category: categoryDiagnostics,
@@ -35,7 +35,7 @@ func NewDoctorCmd() *cli.Command {
 func doctorAction(_ context.Context, cmd *cli.Command) error {
 	report := doctor.Run(doctor.DefaultChecks())
 
-	switch cmd.String("output") {
+	switch cmd.String(flagOutput) {
 	case outputJSON:
 		if err := doctor.WriteJSON(os.Stdout, report); err != nil {
 			return err
@@ -46,7 +46,7 @@ func doctorAction(_ context.Context, cmd *cli.Command) error {
 		}
 	default:
 		return fmt.Errorf("unsupported output format %q (expected %s or %s)",
-			cmd.String("output"), outputText, outputJSON)
+			cmd.String(flagOutput), outputText, outputJSON)
 	}
 
 	if report.HasBlockingFailures() {

cmd/schedctl/info.go

@@ -36,9 +36,9 @@ Examples:
 				Category: categoryProcess,
 			},
 			&cli.StringFlag{
-				Name:     "output",
+				Name:     flagOutput,
 				Aliases:  []string{"o"},
-				Usage:    "output format: text, json",
+				Usage:    flagOutputUsage,
 				Value:    outputText,
 				Local:    true,
 				Category: categoryDisplay,
@@ -56,7 +56,7 @@ func infoAction(_ context.Context, cmd *cli.Command) error {
 
 	schedulerID := args[0]
 	version := cmd.String("version")
-	format := cmd.String("output")
+	format := cmd.String(flagOutput)
 
 	if format != outputText && format != outputJSON {
 		return fmt.Errorf("unsupported --output value %q (expected: %s, %s)", format, outputText, outputJSON)

cmd/schedctl/list_test.go

@@ -16,7 +16,7 @@ func TestNewListCmd(t *testing.T) {
 	listCmd := cmd.NewListCmd()
 
 	assert.NotNil(t, listCmd)
-	assert.Equal(t, "list", listCmd.Name)
+	assert.Equal(t, cmdList, listCmd.Name)
 	assert.Equal(t, "list available schedulers", listCmd.Usage)
 }
 
@@ -27,7 +27,7 @@ func TestListCmdExecute(t *testing.T) {
 	r, w, _ := os.Pipe()
 	os.Stdout = w
 
-	err := rootCmd.Run(context.Background(), []string{"schedctl", "list"})
+	err := rootCmd.Run(context.Background(), []string{"schedctl", cmdList})
 	w.Close()
 	os.Stdout = oldStdout
 

cmd/schedctl/root.go

@@ -18,6 +18,11 @@ const (
 	outputJSON = "json"
 )
 
+const (
+	flagOutput      = "output"
+	flagOutputUsage = "output format: text, json"
+)
+
 func Execute() {
 	rootCmd := NewRootCmd()
 	if err := rootCmd.Run(context.Background(), os.Args); err != nil {

cmd/schedctl/root_test.go

@@ -10,6 +10,8 @@ import (
 	cmd "schedctl/cmd/schedctl"
 )
 
+const cmdList = "list"
+
 func lookupFlag(flags []cli.Flag, name string) cli.Flag {
 	for _, f := range flags {
 		for _, n := range f.Names() {
@@ -42,7 +44,7 @@ func TestNewRootCmd(t *testing.T) {
 func TestRootCmdHasSubcommands(t *testing.T) {
 	rootCmd := cmd.NewRootCmd()
 
-	expected := []string{"run", "ps", "stop", "list", "doctor", "status", "versions", "info"}
+	expected := []string{"run", "ps", "stop", cmdList, "doctor", "status", "versions", "info"}
 	for _, name := range expected {
 		assert.NotNil(t, findSubcommand(rootCmd, name), "Root command should have %s subcommand", name)
 	}

cmd/schedctl/status.go

@@ -34,9 +34,9 @@ Exit codes:
 See schedctl-status(1) for the full JSON schema.`,
 		Flags: []cli.Flag{
 			&cli.StringFlag{
-				Name:     "output",
+				Name:     flagOutput,
 				Aliases:  []string{"o"},
-				Usage:    "output format: text, json",
+				Usage:    flagOutputUsage,
 				Value:    outputText,
 				Local:    true,
 				Category: categoryDisplay,
@@ -48,7 +48,7 @@ See schedctl-status(1) for the full JSON schema.`,
 
 func statusAction(_ context.Context, cmd *cli.Command) error {
 	driver := cmd.String("driver")
-	format := cmd.String("output")
+	format := cmd.String(flagOutput)
 
 	if format != outputText && format != outputJSON {
 		return fmt.Errorf("unsupported --output value %q (expected: %s, %s)", format, outputText, outputJSON)

go.mod

@@ -1,6 +1,6 @@
 module schedctl
 
-go 1.25.8
+go 1.26.3
 
 require (
 	github.com/anatol/vmtest v0.0.0-20230711210602-87511df0d4bc

internal/info/info_test.go

@@ -13,61 +13,73 @@ import (
 	"schedctl/internal/schedulers"
 )
 
+const (
+	rustyImage       = "ghcr.io/schedkit/scx_rusty:latest"
+	rustyDigest      = "sha256:abc"
+	rustyName        = "scx_rusty"
+	rustyDescription = "Rust user-space scheduler"
+	rustyDocs        = "https://example.com/docs"
+	rustySource      = "https://github.com/sched-ext/scx"
+	rustyVersion     = "1.0.0"
+	rustyKernelMin   = "6.12"
+	sparseImage      = "ghcr.io/example/sparse:latest"
+)
+
 func TestBuildPopulatesAllCuratedFields(t *testing.T) {
 	created := time.Date(2026, 4, 1, 12, 0, 0, 0, time.UTC)
 	img := schedulers.SchedulerImage{
-		ImageURI: "ghcr.io/schedkit/scx_rusty:latest",
+		ImageURI: rustyImage,
 		Source:   schedulers.SourceManifest,
 	}
 	raw := schedulers.ImageInfo{
-		ImageRef:     "ghcr.io/schedkit/scx_rusty:latest",
-		Digest:       "sha256:abc",
+		ImageRef:     rustyImage,
+		Digest:       rustyDigest,
 		Created:      &created,
 		Architecture: "amd64",
 		OS:           "linux",
 		Labels: map[string]string{
-			info.LabelTitle:         "scx_rusty",
-			info.LabelDescription:   "Rust user-space scheduler",
-			info.LabelDocumentation: "https://example.com/docs",
-			info.LabelSource:        "https://github.com/sched-ext/scx",
-			info.LabelVersion:       "1.0.0",
+			info.LabelTitle:         rustyName,
+			info.LabelDescription:   rustyDescription,
+			info.LabelDocumentation: rustyDocs,
+			info.LabelSource:        rustySource,
+			info.LabelVersion:       rustyVersion,
 			info.LabelRevision:      "deadbee",
 			info.LabelAuthors:       "scx team",
 			info.LabelLicenses:      "GPL-2.0",
 			info.LabelVendor:        "schedkit",
-			info.LabelKernelMin:     "6.12",
+			info.LabelKernelMin:     rustyKernelMin,
 		},
 	}
 
-	r := info.Build("scx_rusty", img, raw)
+	r := info.Build(rustyName, img, raw)
 
 	assert.Equal(t, info.SchemaVersion, r.SchemaVersion)
-	assert.Equal(t, "scx_rusty", r.Scheduler)
+	assert.Equal(t, rustyName, r.Scheduler)
 	assert.Equal(t, "manifest", r.Source)
-	assert.Equal(t, "ghcr.io/schedkit/scx_rusty:latest", r.ImageRef)
-	assert.Equal(t, "sha256:abc", r.Digest)
+	assert.Equal(t, rustyImage, r.ImageRef)
+	assert.Equal(t, rustyDigest, r.Digest)
 	assert.Equal(t, &created, r.Created)
 	assert.Equal(t, "amd64", r.Architecture)
 	assert.Equal(t, "linux", r.OS)
-	assert.Equal(t, "scx_rusty", r.Title)
-	assert.Equal(t, "Rust user-space scheduler", r.Description)
-	assert.Equal(t, "https://example.com/docs", r.Documentation)
-	assert.Equal(t, "https://github.com/sched-ext/scx", r.SourceURL)
-	assert.Equal(t, "1.0.0", r.Version)
+	assert.Equal(t, rustyName, r.Title)
+	assert.Equal(t, rustyDescription, r.Description)
+	assert.Equal(t, rustyDocs, r.Documentation)
+	assert.Equal(t, rustySource, r.SourceURL)
+	assert.Equal(t, rustyVersion, r.Version)
 	assert.Equal(t, "deadbee", r.Revision)
 	assert.Equal(t, "scx team", r.Authors)
 	assert.Equal(t, "GPL-2.0", r.Licenses)
 	assert.Equal(t, "schedkit", r.Vendor)
-	assert.Equal(t, "6.12", r.KernelMin)
+	assert.Equal(t, rustyKernelMin, r.KernelMin)
 }
 
 func TestBuildOmitsMissingLabels(t *testing.T) {
 	img := schedulers.SchedulerImage{
-		ImageURI: "ghcr.io/example/sparse:latest",
+		ImageURI: sparseImage,
 		Source:   schedulers.SourceDirect,
 	}
 	raw := schedulers.ImageInfo{
-		ImageRef: "ghcr.io/example/sparse:latest",
+		ImageRef: sparseImage,
 		Labels: map[string]string{
 			info.LabelTitle: "sparse",
 		},
@@ -103,11 +115,11 @@ func TestBuildWithEmptyLabelMap(t *testing.T) {
 func TestWriteJSONOmitsEmptyFields(t *testing.T) {
 	r := info.Report{
 		SchemaVersion: info.SchemaVersion,
-		Scheduler:     "scx_rusty",
+		Scheduler:     rustyName,
 		Source:        "manifest",
-		ImageRef:      "ghcr.io/schedkit/scx_rusty:latest",
-		Digest:        "sha256:abc",
-		Title:         "scx_rusty",
+		ImageRef:      rustyImage,
+		Digest:        rustyDigest,
+		Title:         rustyName,
 	}
 	var buf bytes.Buffer
 	err := info.WriteJSON(&buf, r)
@@ -116,8 +128,8 @@ func TestWriteJSONOmitsEmptyFields(t *testing.T) {
 	var decoded map[string]any
 	assert.NoError(t, json.Unmarshal(buf.Bytes(), &decoded))
 	assert.Equal(t, "1", decoded["schema_version"])
-	assert.Equal(t, "scx_rusty", decoded["scheduler"])
-	assert.Equal(t, "sha256:abc", decoded["digest"])
+	assert.Equal(t, rustyName, decoded["scheduler"])
+	assert.Equal(t, rustyDigest, decoded["digest"])
 	_, hasEmpty := decoded["description"]
 	assert.False(t, hasEmpty, "empty fields should be omitted from JSON")
 	_, hasKernel := decoded["kernel_min_version"]
@@ -126,29 +138,29 @@ func TestWriteJSONOmitsEmptyFields(t *testing.T) {
 
 func TestWriteTextIncludesKeyFields(t *testing.T) {
 	r := info.Report{
-		Scheduler:     "scx_rusty",
-		Title:         "scx_rusty",
-		Description:   "Rust user-space scheduler",
-		ImageRef:      "ghcr.io/schedkit/scx_rusty:latest",
-		Digest:        "sha256:abc",
-		KernelMin:     "6.12",
-		Documentation: "https://example.com/docs",
-		SourceURL:     "https://github.com/sched-ext/scx",
-		Version:       "1.0.0",
+		Scheduler:     rustyName,
+		Title:         rustyName,
+		Description:   rustyDescription,
+		ImageRef:      rustyImage,
+		Digest:        rustyDigest,
+		KernelMin:     rustyKernelMin,
+		Documentation: rustyDocs,
+		SourceURL:     rustySource,
+		Version:       rustyVersion,
 	}
 	var buf bytes.Buffer
 	info.WriteText(&buf, r)
 	out := buf.String()
 
 	for _, want := range []string{
-		"scx_rusty",
-		"Rust user-space scheduler",
-		"ghcr.io/schedkit/scx_rusty:latest",
-		"sha256:abc",
-		"6.12",
-		"https://example.com/docs",
-		"https://github.com/sched-ext/scx",
-		"1.0.0",
+		rustyName,
+		rustyDescription,
+		rustyImage,
+		rustyDigest,
+		rustyKernelMin,
+		rustyDocs,
+		rustySource,
+		rustyVersion,
 	} {
 		assert.True(t, strings.Contains(out, want), "expected text output to contain %q", want)
 	}

internal/schedulers/schedulers_test.go

@@ -8,10 +8,12 @@ import (
 	"schedctl/internal/schedulers"
 )
 
+const rustyRepo = "ghcr.io/schedkit/scx_rusty"
+
 func TestSchedulerFound(t *testing.T) {
 	result, err := schedulers.GetScheduler("scx_rusty", "")
 	assert.Nil(t, err)
-	assert.Equal(t, "ghcr.io/schedkit/scx_rusty:latest", result.ImageURI)
+	assert.Equal(t, rustyRepo+":latest", result.ImageURI)
 	assert.Equal(t, schedulers.SourceManifest, result.Source)
 }
 
@@ -65,7 +67,7 @@ func TestInvalidInput(t *testing.T) {
 func TestGetSchedulerWithVersion(t *testing.T) {
 	result, err := schedulers.GetScheduler("scx_rusty", "v1.0.0")
 	assert.Nil(t, err)
-	assert.Equal(t, "ghcr.io/schedkit/scx_rusty:v1.0.0", result.ImageURI)
+	assert.Equal(t, rustyRepo+":v1.0.0", result.ImageURI)
 	assert.Equal(t, schedulers.SourceManifest, result.Source)
 }
 
@@ -81,9 +83,9 @@ func TestImageRepo(t *testing.T) {
 		input    string
 		expected string
 	}{
-		{"ghcr.io/schedkit/scx_rusty:latest", "ghcr.io/schedkit/scx_rusty"},
-		{"ghcr.io/schedkit/scx_rusty", "ghcr.io/schedkit/scx_rusty"},
-		{"ghcr.io/schedkit/scx_rusty@sha256:abc123", "ghcr.io/schedkit/scx_rusty"},
+		{rustyRepo + ":latest", rustyRepo},
+		{rustyRepo, rustyRepo},
+		{rustyRepo + "@sha256:abc123", rustyRepo},
 		{"localhost:5000/myimage:v1", "localhost:5000/myimage"},
 		{"docker.io/nginx:alpine", "docker.io/nginx"},
 	}