This repository was archived by the owner on Jun 16, 2022. It is now read-only.
Merged previous#83
Open
Daniel-KM wants to merge 38 commits into
Open
Conversation
A missing echo line was causing incomplete HTML to be returned.
- get the json data - reformat it to match the TimelineJS format - create a timeline instance
- Refactor to provide function to create an end date - The end date currently does not work and is commented out, along with various logs for debugging - If the record has a file, it is returned in the json with the image key. Take what is there and include it in the slide.
- Remove the old code that created the Simile timeline - Remove old center date code - Make the title of each record's slide a link to the Omeka record
…ing multiple timelines on a single page
The theme-config setting for loading javascripts locally has changed from InternalJavascripts to InternalAssets, to recognize that people will want to use this for css files and such as well. I updated the plugin to accept the old or new syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I merged all previous pull requests and branches.
Sincerely,
Daniel Berthereau
Infodoc & Knowledge management