Fix table rendering regression in preview panel#438
Open
samqbush wants to merge 1 commit into
Open
Conversation
Replace aggressive td/th word-break rules with table-level overflow handling. Wide tables now scroll horizontally instead of compressing columns. The previous word-break: break-word on td/th (added for issue schuyler#30) was never in the upstream MacDownApp/macdown PR #1320 and caused tables to render with unusably narrow columns. The new table rules follow the proven pattern from GitHub-2020.css. Related to schuyler#432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the table rendering regression where tables display with aggressively compressed column widths in the preview panel.
Problem
export.cssappliedword-break: break-wordontd, thelements (added for issue #30), causing table columns to wrap text at every opportunity and compress to unusably narrow widths. This rule was never in the upstream MacDownApp/macdown PR #1320 — it was added during the macdown3000 implementation.Fix
td, th { word-break: break-word }blocktable { display: block; width: max-content; max-width: 100%; overflow: auto; }This follows the proven pattern from GitHub-2020.css (the only theme that previously handled tables correctly). Since
export.cssloads last in the stylesheet cascade, this fix applies to all 11 themes.Behavior Change
body { overflow-wrap: break-word }inheritance (gentler than explicit word-break on cells)Related to #432