-
Notifications
You must be signed in to change notification settings - Fork 72
Expand file tree
/
Copy pathtest_github.py
More file actions
329 lines (281 loc) · 7.63 KB
/
test_github.py
File metadata and controls
329 lines (281 loc) · 7.63 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
import yaml
from repo_review.testing import compute_check
def test_gh100() -> None:
workflows = yaml.safe_load(
"""
ci:
name: CI
"""
)
assert compute_check("GH100", workflows=workflows).result
def test_gh100_missing() -> None:
assert not compute_check("GH100", workflows={}).result
def test_gh101() -> None:
workflows = yaml.safe_load(
"""
ci:
name: CI
docs:
name: Docs
"""
)
assert compute_check("GH101", workflows=workflows).result
def test_gh101_missing_names() -> None:
workflows = yaml.safe_load(
"""
ci:
name: CI
docs:
jobs: {}
"""
)
assert not compute_check("GH101", workflows=workflows).result
def test_gh102() -> None:
workflows = yaml.safe_load(
"""
ci:
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
"""
)
assert compute_check("GH102", workflows=workflows).result
def test_gh102_missing_concurrency() -> None:
workflows = yaml.safe_load(
"""
ci:
jobs: {}
"""
)
assert not compute_check("GH102", workflows=workflows).result
def test_gh103() -> None:
workflows = yaml.safe_load(
"""
ci:
on:
workflow_dispatch:
"""
)
assert compute_check("GH103", workflows=workflows).result
def test_gh103_missing_dispatch() -> None:
workflows = yaml.safe_load(
"""
ci:
on:
push:
"""
)
assert not compute_check("GH103", workflows=workflows).result
def test_gh104() -> None:
workflows = yaml.safe_load(
"""
cd:
jobs:
wheels:
strategy:
matrix:
python: ["3.11", "3.12"]
steps:
- uses: actions/upload-artifact@v4
with:
name: wheels-${{ matrix.python }}
sdist:
steps:
- uses: actions/upload-artifact@v4
with:
name: sdist
- uses: actions/upload-artifact@v4
with:
name: docs
"""
)
assert compute_check("GH104", workflows=workflows).result
def test_gh104_duplicate_names() -> None:
workflows = yaml.safe_load(
"""
cd:
jobs:
wheels:
steps:
- uses: actions/upload-artifact@v4
with:
name: wheel
- uses: actions/upload-artifact@v4
with:
name: wheel
"""
)
res = compute_check("GH104", workflows=workflows)
assert not res.result
assert "Multiple matching upload artifact names" in res.err_msg
def test_gh104_matrix_without_substitution() -> None:
workflows = yaml.safe_load(
"""
cd:
jobs:
wheels:
strategy:
matrix:
python: ["3.11", "3.12"]
steps:
- uses: actions/upload-artifact@v4
with:
name: wheel
"""
)
res = compute_check("GH104", workflows=workflows)
assert not res.result
assert "No variable substitutions were detected" in res.err_msg
def test_gh105_trusted_publishing() -> None:
workflows = yaml.safe_load(
"""
cd:
jobs:
publish:
steps:
- uses: pypa/gh-action-pypi-publish@release/v1
"""
)
assert compute_check("GH105", workflows=workflows).result
def test_gh105_token_based_upload() -> None:
workflows = yaml.safe_load(
"""
cd:
jobs:
publish:
steps:
- uses: pypa/gh-action-pypi-publish@release/v1
with:
password: ${{ secrets.pypi_password }}
"""
)
res = compute_check("GH105", workflows=workflows)
assert not res.result
assert "Token-based publishing" in res.err_msg
def test_gh106_precommit() -> None:
precommit = yaml.safe_load(
"""
repos:
- repo: https://github.com/zizmorcore/zizmor-pre-commit
rev: v1.22.0
hooks:
- id: zizmor
"""
)
assert compute_check("GH106", precommit=precommit, workflows={"ci": {}}).result
def test_gh106_action() -> None:
workflows = yaml.safe_load(
"""
zizmor:
jobs:
zizmor:
steps:
- uses: zizmorcore/zizmor-action@v0.5.6
"""
)
assert compute_check("GH106", precommit={}, workflows=workflows).result
def test_gh106_missing() -> None:
precommit = yaml.safe_load(
"""
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.15.16
hooks:
- id: ruff-check
"""
)
assert not compute_check("GH106", precommit=precommit, workflows={"ci": {}}).result
def test_gh200() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
"""
)
assert compute_check("GH200", dependabot=dependabot).result
def test_gh200_missing() -> None:
assert not compute_check("GH200", dependabot={}).result
def test_gh210() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
"""
)
assert compute_check("GH210", dependabot=dependabot).result
def test_gh210_missing_github_actions() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: pip
directory: "/"
schedule:
interval: weekly
"""
)
assert not compute_check("GH210", dependabot=dependabot).result
def test_gh211() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
ignore:
- dependency-name: pypa/cibuildwheel
"""
)
assert compute_check("GH211", dependabot=dependabot).result
def test_gh211_pins_major_core_actions() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
ignore:
- dependency-name: actions/*
"""
)
assert not compute_check("GH211", dependabot=dependabot).result
def test_gh212() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
groups:
actions:
patterns:
- "*"
"""
)
assert compute_check("GH212", dependabot=dependabot).result
def test_gh212_missing_groups() -> None:
dependabot = yaml.safe_load(
"""
version: 2
updates:
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: weekly
"""
)
assert not compute_check("GH212", dependabot=dependabot).result