allow user-input path to teams.yaml#34
Merged
Merged
Conversation
drammock
commented
Apr 28, 2026
larsoner
reviewed
Apr 28, 2026
larsoner
reviewed
Apr 28, 2026
larsoner
reviewed
Apr 28, 2026
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Member
Author
|
@larsoner all comments addressed. |
larsoner
approved these changes
Apr 28, 2026
Contributor
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
@stefanv or @jarrodmillman did you want to look? If not I'm happy to merge
stefanv
reviewed
Apr 28, 2026
Co-authored-by: Stefan van der Walt <stefan@mentat.za.net>
Member
Author
|
thanks @stefanv good suggestions! |
Contributor
|
Thanks @drammock ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows users to pass in a custom path to the
teams.yamlfile. We wanted this for MNE-Python because we're not storingteams.yamlin a dedicated repo (there will be other admin stuff in there) so we don't want the teams file at repo root.