Make test-code require create-dataset

Author: finsberg

.github/workflows/deploy_pages.yml

@@ -17,16 +17,6 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  create-datasets:
-    uses: ./.github/workflows/create_legacy_data.yml
-    with:
-      artifact_name: "legacy_mpich"
-
-  create-legacy-datasets:
-    uses: ./.github/workflows/create_legacy_checkpoint.yml
-    with:
-      artifact_name: "legacy_checkpoint_mpich"
-
   build-docs:
     uses: ./.github/workflows/build_docs.yml
     with:
@@ -38,7 +28,7 @@ jobs:
       dolfinx_tag: "stable"
 
   deploy:
-    needs: [create-datasets, create-legacy-datasets, build-docs, test-code]
+    needs: [build-docs, test-code]
 
     environment:
       name: github-pages

.github/workflows/test_dolfinx_versions.yml

@@ -6,20 +6,7 @@ on:
   pull_request:
 
 jobs:
-  # 1. Prerequisite jobs (Data creation)
-  create-datasets:
-    uses: ./.github/workflows/create_legacy_data.yml
-    with:
-      artifact_name: "legacy_mpich"
-
-  create-legacy-datasets:
-    uses: ./.github/workflows/create_legacy_checkpoint.yml
-    with:
-      artifact_name: "legacy_checkpoint_mpich"
-
-  # 2. The Matrix Job
   run-tests:
-    needs: [create-datasets, create-legacy-datasets]
     strategy:
       fail-fast: false
       matrix:

.github/workflows/test_workflow.yml

@@ -8,7 +8,20 @@ on:
         type: string
 
 jobs:
+
+  create-datasets:
+    uses: ./.github/workflows/create_legacy_data.yml
+    with:
+      artifact_name: "legacy_mpich"
+
+  create-legacy-datasets:
+    uses: ./.github/workflows/create_legacy_checkpoint.yml
+    with:
+      artifact_name: "legacy_checkpoint_mpich"
+
+
   test-code:
+    needs: [create-datasets, create-legacy-datasets]
     runs-on: ubuntu-24.04
     # The container tag is now dynamic based on the input passed by the caller
     container: ghcr.io/fenics/dolfinx/dolfinx:${{ inputs.dolfinx_tag }}