Merge pull request #19 from scientificcomputing/remove-inpsect-hack

Remove inspect hack - it doesn't work with python< 3.12

Author: finsberg

src/io4dolfinx/checkpointing.py

@@ -6,7 +6,6 @@
 
 from __future__ import annotations
 
-import inspect
 import typing
 from pathlib import Path
 from typing import Any
@@ -436,11 +435,21 @@ def partitioner(comm: MPI.Intracomm, n, m, topo):
             else:
                 return partition_graph
     else:
-        sig = inspect.signature(dolfinx.mesh.create_cell_partitioner)
-        part_kwargs = {}
-        if "max_facet_to_cell_links" in list(sig.parameters.keys()):
-            part_kwargs["max_facet_to_cell_links"] = max_facet_to_cell_links
-        partitioner = dolfinx.cpp.mesh.create_cell_partitioner(ghost_mode, **part_kwargs)
+        try:
+            partitioner = dolfinx.cpp.mesh.create_cell_partitioner(
+                ghost_mode, max_facet_to_cell_links=max_facet_to_cell_links
+            )
+        except TypeError:
+            partitioner = dolfinx.cpp.mesh.create_cell_partitioner(ghost_mode)
+
+        # Should change to the commented code below when we require python
+        # minimum version to be >=3.12 see https://github.com/python/cpython/pull/116198
+        # import inspect
+        # sig = inspect.signature(dolfinx.mesh.create_cell_partitioner)
+        # part_kwargs = {}
+        # if "max_facet_to_cell_links" in list(sig.parameters.keys()):
+        #     part_kwargs["max_facet_to_cell_links"] = max_facet_to_cell_links
+        # partitioner = dolfinx.cpp.mesh.create_cell_partitioner(ghost_mode, **part_kwargs)
 
     return dolfinx.mesh.create_mesh(
         comm,

src/io4dolfinx/readers.py

@@ -6,7 +6,6 @@
 
 from __future__ import annotations
 
-import inspect
 import pathlib
 import typing
 from pathlib import Path
@@ -181,19 +180,41 @@ def read_mesh_from_legacy_h5(
         shape=(mesh_geometry.shape[1],),
     )
     domain = ufl.Mesh(element)
-    sig = inspect.signature(dolfinx.mesh.create_mesh)
-    kwargs: dict[str, int] = {}
-    if "max_facet_to_cell_links" in list(sig.parameters.keys()):
-        kwargs["max_facet_to_cell_links"] = max_facet_to_cell_links
-
-    return dolfinx.mesh.create_mesh(
-        comm=MPI.COMM_WORLD,
-        cells=mesh_topology,
-        x=mesh_geometry,
-        e=domain,
-        partitioner=None,
-        **kwargs,
-    )
+
+    try:
+        return dolfinx.mesh.create_mesh(
+            comm=MPI.COMM_WORLD,
+            cells=mesh_topology,
+            x=mesh_geometry,
+            e=domain,
+            partitioner=None,
+            max_facet_to_cell_links=max_facet_to_cell_links,
+        )
+    except TypeError:
+        return dolfinx.mesh.create_mesh(
+            comm=MPI.COMM_WORLD,
+            cells=mesh_topology,
+            x=mesh_geometry,
+            e=domain,
+            partitioner=None,
+        )
+
+    # Should change to the commented code below when we require python
+    # minimum version to be >=3.12 see https://github.com/python/cpython/pull/116198
+    # import inspect
+    # sig = inspect.signature(dolfinx.mesh.create_mesh)
+    # kwargs: dict[str, int] = {}
+    # if "max_facet_to_cell_links" in list(sig.parameters.keys()):
+    #     kwargs["max_facet_to_cell_links"] = max_facet_to_cell_links
+
+    # return dolfinx.mesh.create_mesh(
+    #     comm=MPI.COMM_WORLD,
+    #     cells=mesh_topology,
+    #     x=mesh_geometry,
+    #     e=domain,
+    #     partitioner=None,
+    #     **kwargs,
+    # )
 
 
 def read_function_from_legacy_h5(