Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
voxel_fit_function,curve_fit_wrapper, andfit_voxelfromutils.pytolookclocker.py(because they are only used here).estimate_se_free_relaxation_timeandT1_lookup_tablefromutils.pytomixed.pyR1_from_concentration_exprandT1_from_concentration_expr.I also improved the typing in some of these function. For example consider the following function
According to the type-annotation,
t1needs to by a numpy array. However we know thatt1can also by a float, but in that caset1_0and the return value should also by a float. We can specify this using a type variable as followsHere we also explicity bound the type variable to either a numpy array or a float (meaning that these are the only accepted types).