Fix expressions on facets and interpolation on facet submeshes#225
Merged
Conversation
for more information, see https://pre-commit.ci
jorgensd
changed the title
Member
Author
|
@finsberg i need to add a conditional for the reversion of points based on version. Will do that later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEniCS/dolfinx#4140 introduces a consistent global orentation of the expression points when evaluated at facets. This needs to be taken into account when we build the BC.
Also fixes the parametrization of the test of bcs for quads and hexes (previously just simplex in disguise).
New feature
scifem.interpolation.interpolate_to_surface_submeshnow works for discontinuous elements.