fix: declare --annotate HTML output as a byproduct#90
Merged
Conversation
Cython's -a/--annotate (and --annotate-fullc/--annotate-coverage) generate a colorized .html file next to the .c/.cxx output, but cython_transpile never told CMake about it. It wasn't tracked for `clean` and Ninja didn't know it existed. Declare it as a BYPRODUCTS of the add_custom_command when detected in CYTHON_ARGS. Assisted-by: ClaudeCode:claude-sonnet-5
henryiii
force-pushed
the
fix/annotate-byproducts
branch
from
July 9, 2026 20:49
53ef9f0 to
bb401a6
Compare
MSBuild's clean target does not remove custom-command BYPRODUCTS, so the simple.html assertion failed on Windows CI. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as ready for review
July 9, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Cython's
-a/--annotate(and--annotate-fullc/--annotate-coverage) options generate a colorized.htmlfile next to the generated.c/.cxxsource, butcython_transpilenever declared it to CMake. It wasn't tracked forcleanand Ninja had no idea it existed.This detects annotate-related flags in the effective
CYTHON_ARGS(including inside a$<...>generator expression) and adds the.htmlfile as aBYPRODUCTSof theadd_custom_command.Addresses item 6 of #84.