Skip to content

Commit 733c054

Browse files
eirrganghenryiii
authored andcommitted
Properly mark the test cases that are expected to fail.
1 parent f13e2f7 commit 733c054

1 file changed

Lines changed: 72 additions & 0 deletions

File tree

tests/test_editable_generated.py

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,18 @@
2222
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
2323
@pytest.mark.usefixtures("package")
2424
@pytest.mark.usefixtures("isolate")
25+
@pytest.mark.parametrize(
26+
"editable",
27+
[
28+
pytest.param(None, id="not_editable"),
29+
"redirect",
30+
pytest.param(
31+
"inplace",
32+
marks=pytest.mark.skip(
33+
"`inplace` editable mode requires build tree layout to match package layout."))
34+
],
35+
indirect=True
36+
)
2537
@pytest.mark.skipif(
2638
sys.version_info < (3, 9),
2739
reason="importlib.resources.files is introduced in Python 3.9",
@@ -54,6 +66,18 @@ def test_basic_data_resources(editable, isolated):
5466
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
5567
@pytest.mark.usefixtures("package")
5668
@pytest.mark.usefixtures("isolate")
69+
@pytest.mark.parametrize(
70+
"editable",
71+
[
72+
pytest.param(None, id="not_editable"),
73+
pytest.param("redirect", marks=pytest.mark.xfail(reason="Redirection requires #808", strict=True)),
74+
pytest.param(
75+
"inplace",
76+
marks=pytest.mark.skip(
77+
"`inplace` editable mode requires build tree layout to match package layout."))
78+
],
79+
indirect=True
80+
)
5781
@pytest.mark.skipif(
5882
sys.version_info < (3, 9),
5983
reason="importlib.resources.files is introduced in Python 3.9",
@@ -76,6 +100,18 @@ def test_configure_time_generated_data(editable, isolated):
76100
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
77101
@pytest.mark.usefixtures("package")
78102
@pytest.mark.usefixtures("isolate")
103+
@pytest.mark.parametrize(
104+
"editable",
105+
[
106+
pytest.param(None, id="not_editable"),
107+
pytest.param("redirect", marks=pytest.mark.xfail(reason="Redirection requires #808", strict=True)),
108+
pytest.param(
109+
"inplace",
110+
marks=pytest.mark.skip(
111+
"`inplace` editable mode requires build tree layout to match package layout."))
112+
],
113+
indirect=True
114+
)
79115
@pytest.mark.skipif(
80116
sys.version_info < (3, 9),
81117
reason="importlib.resources.files is introduced in Python 3.9",
@@ -98,6 +134,18 @@ def test_build_time_generated_data(editable, isolated):
98134
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
99135
@pytest.mark.usefixtures("package")
100136
@pytest.mark.usefixtures("isolate")
137+
@pytest.mark.parametrize(
138+
"editable",
139+
[
140+
pytest.param(None, id="not_editable"),
141+
pytest.param("redirect", marks=pytest.mark.xfail(reason="Redirection requires #808", strict=True)),
142+
pytest.param(
143+
"inplace",
144+
marks=pytest.mark.skip(
145+
"`inplace` editable mode requires build tree layout to match package layout."))
146+
],
147+
indirect=True
148+
)
101149
@pytest.mark.skipif(
102150
sys.version_info < (3, 9),
103151
reason="importlib.resources.files is introduced in Python 3.9",
@@ -120,6 +168,18 @@ def test_compiled_ctypes_resource(editable, isolated):
120168
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
121169
@pytest.mark.usefixtures("package")
122170
@pytest.mark.usefixtures("isolate")
171+
@pytest.mark.parametrize(
172+
"editable",
173+
[
174+
pytest.param(None, id="not_editable"),
175+
"redirect",
176+
pytest.param(
177+
"inplace",
178+
marks=pytest.mark.skip(
179+
"`inplace` editable mode requires build tree layout to match package layout."))
180+
],
181+
indirect=True
182+
)
123183
@pytest.mark.skipif(
124184
sys.version_info < (3, 9),
125185
reason="importlib.resources.files is introduced in Python 3.9",
@@ -172,6 +232,18 @@ def test_configure_time_generated_module(editable, isolated):
172232
@pytest.mark.parametrize("package", ["cmake_generated"], indirect=True)
173233
@pytest.mark.usefixtures("package")
174234
@pytest.mark.usefixtures("isolate")
235+
@pytest.mark.parametrize(
236+
"editable",
237+
[
238+
pytest.param(None, id="not_editable"),
239+
"redirect",
240+
pytest.param(
241+
"inplace",
242+
marks=pytest.mark.skip(
243+
"`inplace` editable mode requires build tree layout to match package layout."))
244+
],
245+
indirect=True
246+
)
175247
@pytest.mark.skipif(
176248
sys.version_info < (3, 9),
177249
reason="importlib.resources.files is introduced in Python 3.9",

0 commit comments

Comments
 (0)