Skip to content

Commit cf5d3dd

Browse files
authored
ci: require scikit-build>=0.19.1 for MSVC 2026 (#72)
scikit-build 0.19.1 (classic) supports Visual Studio 2026, so bump the build floor in the legacy projects and move the checks matrix back to windows-latest (now VS2026). Assisted-by: ClaudeCode:claude-opus-4.8
1 parent 752c755 commit cf5d3dd

7 files changed

Lines changed: 7 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
# Pin Windows to 2022 (VS2022); windows-latest moved to VS2026,
25-
# which classic scikit-build does not yet support.
26-
runs-on: [ubuntu-latest, macos-14, windows-2022]
24+
runs-on: [ubuntu-latest, macos-14, windows-latest]
2725
session: [dist, test]
2826

2927
name: ${{ matrix.session }} on ${{ matrix.runs-on }}

projects/hello-cmake-package/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools>=42",
4-
"scikit-build",
4+
"scikit-build>=0.19.1",
55
"cmake>=3.14",
66
"ninja",
77
"pybind11>=2.12"

projects/hello-cpp/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools>=42",
4-
"scikit-build>=0.13",
4+
"scikit-build>=0.19.1",
55
"cmake>=3.18",
66
"ninja",
77
]

projects/hello-cython/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools>=42",
4-
"scikit-build>=0.13",
4+
"scikit-build>=0.19.1",
55
"cmake>=3.18",
66
"ninja",
77
"cython",

projects/hello-pure/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools>=42",
4-
"scikit-build>=0.13",
4+
"scikit-build>=0.19.1",
55
"cmake>=3.18",
66
"ninja",
77
]

projects/hello-pybind11/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools",
4-
"scikit-build>=0.13",
4+
"scikit-build>=0.19.1",
55
"cmake",
66
"ninja",
77
]

projects/pen2-cython/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[build-system]
22
requires = [
33
"setuptools>=42",
4-
"scikit-build>=0.13",
4+
"scikit-build>=0.19.1",
55
"cmake>=3.18",
66
"ninja",
77
"cython",

0 commit comments

Comments
 (0)