feat(core-nanobind-shared): add nanobind + shared library sample#76
Merged
Conversation
Adds the example requested in scikit-build/scikit-build-core#1034: a nanobind extension module linked against a plain C++ shared library shipped inside the wheel, covering relative install destinations, $ORIGIN/@loader_path RPATH, and Windows DLL/import-library handling. Assisted-by: ClaudeCode:claude-fable-5
Generalizes the free-threading job into a package matrix so the shared-library wheel goes through auditwheel/delocate repair in CI. Assisted-by: ClaudeCode:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Adds the example requested in scikit-build/scikit-build-core#1034: a nanobind extension module that links against an ordinary C++ shared library (
add_library(... SHARED ...)) shipped inside the wheel.The README and CMake comments cover the parts the issue thread flagged as non-trivial: relative
install()destinations,$ORIGIN/@loader_pathRPATH so the extension finds the library next to itself, and Windows handling (DLL next to the.pyd, MSVC import library excluded from the wheel).Wired into
hello_listinnoxfile.py, so it is tested and dist-built on all three CI platforms. Verified locally on macOS: wheel contains only the package files, RPATH checks out withotool, and the wheel imports from a clean venv.