Skip to content

chore: add prettier to pre-commit hook configuration#2538

Open
tkoyama010 wants to merge 2 commits into
scikit-hep:mainfrom
tkoyama010:patch-1
Open

chore: add prettier to pre-commit hook configuration#2538
tkoyama010 wants to merge 2 commits into
scikit-hep:mainfrom
tkoyama010:patch-1

Conversation

@tkoyama010

@tkoyama010 tkoyama010 commented Aug 21, 2024

Copy link
Copy Markdown

Description

  • Please first read CONTRIBUTING.md.
  • Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.

Add prettier to pre-commit hook configuration.
ref PC180 in Scientific Python Library Development Guide.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR

@tkoyama010

Copy link
Copy Markdown
Author

pre-commit.ci autofix

@matthewfeickert matthewfeickert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tkoyama010. I'll talk with @kratsg about this, but we've avoided enabling prettier in the past because of it causing regular breakage (example: prettier/prettier#15742) without adding much benefit.

@tkoyama010

Copy link
Copy Markdown
Author

Thanks for the PR @tkoyama010. I'll talk with @kratsg about this, but we've avoided enabling prettier in the past because of it causing regular breakage (example: prettier/prettier#15742) without adding much benefit.

Thanks for comment. Closing this :)

@matthewfeickert

Copy link
Copy Markdown
Member

@tkoyama010 I'm reopening this PR for now so that @kratsg and I can discuss it. I don't want to close your contribution prematurely! :)

@tkoyama010

tkoyama010 commented Aug 21, 2024

Copy link
Copy Markdown
Author

@tkoyama010 I'm reopening this PR for now so that @kratsg and I can discuss it. I don't want to close your contribution prematurely! :)

Sorry. It was just before I got on the train and I was in a rush.

@codecov

codecov Bot commented Aug 21, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.21%. Comparing base (990681d) to head (d36f4d9).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2538   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants