Skip to content

feat: read TMatrixTSym from TTree#220

Merged
ariostas merged 1 commit intoscikit-hep:mainfrom
mrzimu:mrzimu/add-test-file-for-uproot-pr-1610
Mar 31, 2026
Merged

feat: read TMatrixTSym from TTree#220
ariostas merged 1 commit intoscikit-hep:mainfrom
mrzimu:mrzimu/add-test-file-for-uproot-pr-1610

Conversation

@mrzimu
Copy link
Copy Markdown
Contributor

@mrzimu mrzimu commented Mar 30, 2026

This PR uploads a test file for scikit-hep/uproot5#1610.

The file is generated by COMET analysis framework and the streamer information of TMatrixTSym<double> is missed.

I can't reproduce this issue without the framework, so there is no generation script.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.51%. Comparing base (170a63b) to head (5a4db71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files           4        4           
  Lines         131      131           
=======================================
  Hits           95       95           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrzimu
Copy link
Copy Markdown
Contributor Author

mrzimu commented Mar 30, 2026

@ariostas just a reminder: Could you please take a look at this? Thanks!

Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mrzimu! Looks good to me. In this case I think it's fine to not have a reproducer. There are various other files here that are "broken", but that should still be readable.

I'll merge tomorrow in case someone else has comments.

@ariostas ariostas merged commit ee60b9c into scikit-hep:main Mar 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants