fix: implement report=True for RNTuple.iterate#1630
Open
KaranSinghDev wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1628
RNTuple.iterateaccepted areportparameter but never used it. As a result:uproot.iterate("file.root:rntuple", report=True)crashed withValueError: too many values to unpack (expected 2)atsrc/uproot/behaviors/TBranch.py:216.rn.iterate(report=True)silently returned a bareArrayinstead of the(arrays, Report)tuple that the docstring promises.I have added the regression test (
tests/test_1630_rntuple_iterate_report.py), mirroring the format of the existing TTree iterate-report tests intests/test_0043_iterate_function.py.This PR yields
(arrays, Report)whenreport=True, matching the TTree contract. Thereport=Falsepath is unchanged.