Fix prediction data not honoring cluster_selection_epsilon#586
Open
n9Mtq4 wants to merge 1 commit intoscikit-learn-contrib:masterfrom
Open
Fix prediction data not honoring cluster_selection_epsilon#586n9Mtq4 wants to merge 1 commit intoscikit-learn-contrib:masterfrom
n9Mtq4 wants to merge 1 commit intoscikit-learn-contrib:masterfrom
Conversation
5a4944a to
809c35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with prediction data not using
cluster_selection_epsilon. This bug surfaces with wrong predictions fromapproximate_predictand incorrectexemplars_.Code to reproduce the problem:
I tracked the issue down to prediction data selecting the clusters from the tree differently to how it's done in
_hdbscan_tree.pyx. The fix is to return the selected clusters fromget_clustersin_hdbscan_tree.pyxand use the same clusters for prediction.With this PR:
This likely fixes #308