Add __version__ support#615
Open
LakshmanKishore wants to merge 1 commit intoscikit-learn-contrib:masterfrom
Open
Add __version__ support#615LakshmanKishore wants to merge 1 commit intoscikit-learn-contrib:masterfrom
LakshmanKishore wants to merge 1 commit intoscikit-learn-contrib:masterfrom
Conversation
Author
|
Dear maintainers, I kindly request that you consider tagging this contribution with the 'hacktoberfest-accepted' label or adding the 'hacktoberfest' topic to the repository. This would make it easier for participants in Hacktoberfest to find and contribute to this project. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I have made the following changes to improve version management in the
hdbscanproject:version.pyin thehdbscanfolder.VERSIONwithinversion.pyto store the version of the package.version.pyfor version information.Details:
In the past, the version of the
hdbscanpackage used to be updated directly in thesetup.pyfile. With these changes, we now store the version in theversion.pyfile, which is accessible in both the__init__.pyandsetup.pyfiles. This approach follows the common Python practice of managing the version in a dedicated file for improved consistency and ease of access.Expected Behavior:
After this change, the version of the
hdbscanpackage can be consistently accessed fromversion.pyand can be easily imported into other parts of the project, including the__init__.pyandsetup.pyfiles. Users can now access the package version usinghdbscan.__version__.