-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: Use skore for evaluation models #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glemaitre
wants to merge
3
commits into
scikit-learn-contrib:master
Choose a base branch
from
glemaitre:use_skore
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Column renaming in the results table has no effect because the returned value is discarded
The renamed results table is never stored back (
results.rename(...)atexamples/applications/plot_impact_imbalanced_classes.py:219-228), so the example displays the original auto-generated column names instead of the human-readable estimator names.Impact: The rendered example in the documentation shows cryptic default column identifiers instead of descriptive names like "Dummy classifier" or "Logistic regression".
DataFrame.rename() returns a new object by default
pandas.DataFrame.rename()does not modify the DataFrame in place unlessinplace=Trueis passed. The code at lines 219–228 callsresults.rename(...)but discards the return value. The dictionary comprehension correctly maps old column names to new human-readable names from theestimatorslist, but since the result is never assigned (e.g.results = results.rename(...)) or displayed, the rename is silently lost. The cell in the rendered notebook will show nothing because the last expression in the cell is the discarded return value ofrename, notresultsitself — but even if it were displayed, it would show the un-renamed columns.Was this helpful? React with 👍 or 👎 to provide feedback.