Skip to content

MAINT replace deprecated scipy distance_matrix with cdist #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaoz23 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −2
Open

MAINT replace deprecated scipy distance_matrix with cdist #1188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/whats_new/v0.15.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,12 @@ Enhancements
Compatibility
.............

- Replace the deprecated ``scipy.spatial.distance_matrix`` with
``scipy.spatial.distance.cdist`` (Minkowski metric) in
:class:`~imblearn.metrics.pairwise.ValueDifferenceMetric`. This silences a
``DeprecationWarning`` under SciPy 1.18 (the function is scheduled for
removal in SciPy 1.20); the computed distances are unchanged.
:pr:`1188` by :user:`chaoz23`.

Deprecations
............
5 changes: 3 additions & 2 deletions imblearn/metrics/pairwise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import numbers

import numpy as np
from scipy.spatial import distance_matrix
from scipy.spatial.distance import cdist
from sklearn.base import BaseEstimator
from sklearn.utils import check_consistent_length
from sklearn.utils._param_validation import StrOptions
Expand Down Expand Up @@ -227,7 +227,8 @@ def pairwise(self, X, Y=None):
else:
proba_feature_Y = proba_feature_X
distance += (
distance_matrix(proba_feature_X, proba_feature_Y, p=self.k) ** self.r
cdist(proba_feature_X, proba_feature_Y, metric="minkowski", p=self.k)
** self.r
)
return distance

Expand Down