Making the trace component of SparseKernelNormalizer more memory-frie…#219
Open
rosecers wants to merge 4 commits into
Open
Making the trace component of SparseKernelNormalizer more memory-frie…#219rosecers wants to merge 4 commits into
rosecers wants to merge 4 commits into
Conversation
agoscinski
approved these changes
Nov 20, 2023
Co-authored-by: Alexander Goscinski <alex.goscinski@posteo.de>
rosecers
force-pushed
the
fix/memory_overload
branch
from
a8ccfe6 to
ca19af2
Compare
Collaborator
|
What is the status here? Seems like we have to fix some assertions in the |
ceriottm
approved these changes
Jul 15, 2025
Collaborator
|
@rosecers if you have a look, we can maybe merge this finally? |
rosecers
commented
Jul 15, 2025
| ) | ||
|
|
||
| self.scale_ = np.sqrt(np.trace(Khat) / Knm.shape[0]) | ||
| self.scale_ = Khat_trace / Knm.shape[0] |
Collaborator
Author
There was a problem hiding this comment.
Where did the square root go to?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndly
Using the equality of traces under cyclic products, I've modified the sparse kernel
normalizer to be less memory-hungry. Had a few issues using this and having RAM crash
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--219.org.readthedocs.build/en/219/