Run a scheduled test on scikit-learn dev version#261
Merged
Conversation
Collaborator
Author
|
I have no idea what is going on with codecov but maybe lets ignore it for now xD... |
Collaborator
Codecov coverage is now below the 95% threshold, so we need to add more tests and increase the coverage! |
Luthaf
approved these changes
Jun 30, 2025
Luthaf
left a comment
Luthaf
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, can you try to add more coverage anyway? My guess is that some code updated somewhere, and now some lines no longer count as covered.
Collaborator
Author
|
Yes, I will set it to 90% for now and open issue to investigate what is going on and add more tests to lift it again above 95%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some recent issues breaking API changes on the scikit-learn. We should see these issues coming earlier before opening a random PR after a release!
I added a test environment that pulls the latest version from the main branch and runs the test suite against this version. You can run this environment by typing
The environment is not run by default and within a new PR but only based on a schedule: Mondays at 10:00 in the GitHub time zone.
📚 Documentation preview 📚: https://scikit-matter--261.org.readthedocs.build/en/261/