Fixing pcovc scaling#270
Merged
Merged
Conversation
rosecers
previously approved these changes
Sep 19, 2025
rosecers
dismissed
their stale review
Did not see tests were failing, please check!
Collaborator
|
Yes I check the failures in a different PR |
Collaborator
Author
|
Forgot to fix doctests, whoops! Everything should be good now. |
rosecers
approved these changes
Sep 24, 2025
rosecers
left a comment
rosecers
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! I like the default behavior being a warning versus automatic scaling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some instances of using PCovC, the latent space will "converge" very quickly with changing alpha. This happens because Z is not necessarily O(1) when computed within the
fitcall. This PR solves this by adding an argument to have a StandardFlexibleScaler call withinfitthat scales Z and W.This will break backwards compatibility but can be made backwards compatible by usingscale_z=False.Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--270.org.readthedocs.build/en/270/